Re: [meta-oe][PATCH 1/4] rrdtool: fix useless-rpath QA issue

[ChenQi <Qi.Chen@windriver.com>]

On 10/20/2015 11:57 PM, Martin Jansa wrote:
> On Tue, Oct 13, 2015 at 10:43:55AM +0800, Chen Qi wrote:
>> When building rrdtool, we would meet the following error.
> Now it fails for qemuarm and qemux86, not sure which change is causing
> that:
>
> http://errors.yoctoproject.org/Errors/Details/20597/
> http://errors.yoctoproject.org/Errors/Details/20601/
>

I'm looking into this problem today, although I currently have some 
problem reproducing it.
I'll look at the logs and try to find out something.

Regards,
Chen Qi

>>    ERROR: QA Issue: rrdtool-python: work/core2-64-poky-linux/rrdtool
>>    /1.5.4-r0/packages-split/rrdtool-python/usr/lib/python2.7/site-packages
>>    /rrdtool.so contains probably-redundant RPATH /usr/lib [useless-rpaths]
>>
>> Fix this issue by removing the redundante RPATH section from rrdtool.so.
>>
>> As we use '--disable-rpath' in EXTRA_OECONF, we don't need to the `sed'
>> line in do_configure.
>>
>> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
>> ---
>>   meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> index 91a30cf..f2ded65 100644
>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.5.4.bb
>> @@ -71,7 +71,6 @@ do_configure() {
>>       PYTHON_INCLUDES="-I=/usr/include/python${PYTHON_BASEVERSION}"' \
>>           ${S}/m4/acinclude.m4
>>       #remove the hardcoded $(libdir) rpath
>> -    sed -i -e 's|--rpath=$(libdir)||g' ${S}/bindings/Makefile.am
>>   
>>       autotools_do_configure
>>   
>> @@ -100,6 +99,11 @@ do_configure() {
>>           ${B}/examples/*.pl
>>   }
>>   
>> +do_compile_append() {
>> +    # Remove useless rpath
>> +    find ${B}/bindings/python/build -name "rrdtool.so" | xargs chrpath -d
>> +}
>> +
>>   PACKAGES =+ "${PN}-perl ${PN}-python"
>>   
>>   FILES_${PN}-doc += "${datadir}/examples"
>> -- 
>> 1.9.1
>>