Re: [PATCH 5/8] cim-schema-exper: fix host-user-contaminated

[Robert Yang <liezhi.yang@windriver.com>]

On 11/20/2015 05:42 PM, Martin Jansa wrote:
> On Fri, Nov 20, 2015 at 01:32:44AM -0800, Robert Yang wrote:
>> Issue: LIN8-1632
>>
>> Fixed:
>> cim-schema-exper-2.39.0: cim-schema-exper: /cim-schema-exper/usr/share/mof/cimv2.39.0/Network/CIM_IPAddressRange.mof is owned by uid 15220, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
>> cim-schema-final-2.40.0: cim-schema-final: /cim-schema-final/usr/share/mof/cimv2.40.0/Network/CIM_IPAddressRange.mof is owned by uid 15220, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
>> lib32-cim-schema-exper-2.39.0: lib32-cim-schema-exper: /lib32-cim-schema-exper/usr/share/mof/cimv2.39.0/Network/CIM_IPAddressRange.mof is owned by uid 15220, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
>> lib32-cim-schema-final-2.40.0: lib32-cim-schema-final: /lib32-cim-schema-final/usr/share/mof/cimv2.40.0/Network/CIM_IPAddressRange.mof is owned by uid 15220, which is the same as the user running bitbake. This may be due to host contamination [host-user-contaminated]
>>
>> It uses cp -a to install the files, so fix the owner to root:root
>>
>> (LOCAL REV: NOT UPSTREAM) -- Sent to oe-devel on 20151120
>>
>> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
>> ---
>>   .../cim-schema/cim-schema-exper_2.39.0.bb          |    1 +
>>   .../cim-schema/cim-schema-final_2.40.0.bb          |    1 +
>>   2 files changed, 2 insertions(+)
>>
>> diff --git a/meta-networking/recipes-support/cim-schema/cim-schema-exper_2.39.0.bb b/meta-networking/recipes-support/cim-schema/cim-schema-exper_2.39.0.bb
>> index 62e50df..e4ed7b3 100644
>> --- a/meta-networking/recipes-support/cim-schema/cim-schema-exper_2.39.0.bb
>> +++ b/meta-networking/recipes-support/cim-schema/cim-schema-exper_2.39.0.bb
>> @@ -17,6 +17,7 @@ do_install() {
>>           install -m 644 ${WORKDIR}/LICENSE ${D}${datadir}/doc/cim-schema-${PV}
>>
>>           cp -a ${S}/* ${D}${datadir}/mof/cimv${PV}/	
>> +        chown -R root:root ${D}${datadir}/mof/cimv${PV}
>
> Why don't you fix it to use install instead of cp -a + chown?

Because there are a lot of files and directories:

$ find cim-schema-exper/image/usr/share/mof/cimv2.39.0/ -type f |wc -l
1816

$ find cim-schema-exper/image/usr/share/mof/cimv2.39.0/ -type d |wc -l
15

I think that's why it used cp -a before. And we did use chown to fix such
issues for several recipes in oe-core and meta-openembedded.

// Robert

>
>>           for i in `find ${D}${datadir}/mof/cimv${PV} -name "*.mof"`; do
>>                   sed -i -e 's/\r//g' $i
>>           done
>> diff --git a/meta-networking/recipes-support/cim-schema/cim-schema-final_2.40.0.bb b/meta-networking/recipes-support/cim-schema/cim-schema-final_2.40.0.bb
>> index 1694f31..7ab9c4d 100644
>> --- a/meta-networking/recipes-support/cim-schema/cim-schema-final_2.40.0.bb
>> +++ b/meta-networking/recipes-support/cim-schema/cim-schema-final_2.40.0.bb
>> @@ -22,6 +22,7 @@ do_install() {
>>           install -m 644 ${WORKDIR}/LICENSE ${D}${datadir}/doc/cim-schema-${PV}
>>
>>           cp -a ${S}/* ${D}${datadir}/mof/cimv${PV}/	
>> +        chown -R root:root ${D}${datadir}/mof/cimv${PV}/
>>           for i in `find ${D}${datadir}/mof/cimv${PV} -name "*.mof"`; do
>>                   sed -i -e 's/\r//g' $i
>>           done
>> --
>> 1.7.9.5
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
>