Re: [meta-oe][PATCH] thrift: Add recipe for Apache Thrift.

[Philip Balister <philip@balister.org>]

Thanks. Too much excitement over the output doing something useful. I
need to get this off my local tree since I know of at least one other
person working with thrift.

I'll update and resend.

Philip

On 12/22/2015 05:52 PM, Andre McCurdy wrote:
>  On Tue, Dec 22, 2015 at 11:43 AM, Philip Balister <philip@balister.org> wrote:
>>  * Run tested cpp bindings with GNU Radio Control Port.
>>
>> Signed-off-by: Philip Balister <philip@balister.org>
>> ---
>>  .../recipes-connectivity/thrift/thrift_0.9.3.bb    | 30 ++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>  create mode 100644 meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
>>
>> diff --git a/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb b/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
>> new file mode 100644
>> index 0000000..43b93cd
>> --- /dev/null
>> +++ b/meta-oe/recipes-connectivity/thrift/thrift_0.9.3.bb
>> @@ -0,0 +1,30 @@
> 
> Maybe add SUMMARY, DESCRIPTION and HOMEPAGE ?
> 
>> +LICENSE = "Apache-2.0"
>> +LIC_FILES_CHKSUM = "file://LICENSE;md5=e4ed21f679b2aafef26eac82ab0c2cbf"
>> +
>> +SRC_URI = "git://git-wip-us.apache.org/repos/asf/thrift.git;protocol=https \
>> +"
>> +SRCREV = "61b8a29b0704ccd81b520f2300f5d1bb261fea3e"
>> +S = "${WORKDIR}/git"
>> +
>> +DEPENDS = "thrift-native boost python libevent flex-native bison-native openssl"
> 
> Move DEPENDS above SRC_URI.
> 
>> +BBCLASSEXTEND = "native nativesdk"
>> +
>> +inherit pkgconfig cmake pythonnative
>> +
>> +export STAGING_INCDIR
>> +export STAGING_LIBDIR
>> +export BUILD_SYS
>> +export HOST_SYS
>> +
>> +EXTRA_OECMAKE = "-DWITH_QT4=OFF"
>> +EXTRA_OECMAKE_append_class-native = "-DWITH_QT4=OFF -DBUILD_TESTING=OFF \
>> +             -DBUILD_EXAMPLES=OFF -DWITH_CPP=OFF"
> 
> -DWITH_QT4=OFF is duplicated and _append without a leading space looks dubious.
> 
> Maybe better for the native and nativesdk classes to just over-ride
> EXTRA_OECMAKE rather than try to append?
> 
>> +EXTRA_OECMAKE_append_class-nativesdk = "-DBUILD_TESTING=OFF \
>> +             -DBUILD_EXAMPLES=OFF -DWITH_PYTHON=OFF"
>> +
>> +do_install_append () {
>> +       cd ${D}/${bindir}
>> +       ln -sf thrift thrift-compiler
> 
> Perhaps drop the unnecessary cd, ie:
> 
>   ln -sf thrift ${D}/${bindir}/thrift-compiler
> 
>> +}
>> +
>> --
>> 2.1.0
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel