Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Javier Viguera <javier.viguera@digi.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-qt5][master][jethro][PATCH] qtconnectivity, qtsystems: fix bluetooth support
Date: Mon, 4 Jan 2016 17:39:39 +0100	[thread overview]
Message-ID: <568AA04B.8000101@digi.com> (raw)
In-Reply-To: <20160104161718.GA2378@jama>

On 04/01/16 17:17, Martin Jansa wrote:
>
> Is it deterministic?
>
> Will it always pick bluez4 when BLUEZ is set to bluez4, but there is
> bluez5 is already in the sysroot as well?

No, BLUEZ is set by *bluetooth* class depending on your distro features 
and is only used to add 'bluez4' or 'bluez5' to the recipe build-time 
dependences (DEPENDS). But apart from that it does nothing to the QT5 
compilation itself.

>
> config.tests/bluez/bluez.pro is only using pkgconfig to find bluez, so
> I'm not sure which one will win.

Neither do I, but I don't think having both versions of the bluez 
libraries in the sysroot is a common use-case. The package config file 
for bluez4 and bluez5 is almost the same. It adds the same cflags and 
libs to any package querying it:

Libs: -L${libdir} -lbluetooth
Cflags: -I${includedir}

So to recap: this change fix the bluetooth support which is currently 
broken because QMAKE_CACHE_EVAL is not used at all, and also allows to 
build QT5 bluetooth support using bluez5 instead of the hard-coded bluez4.

-- 
Regards,

Javier Viguera


  reply	other threads:[~2016-01-04 16:39 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-04 15:59 [meta-qt5][master][jethro][PATCH] qtconnectivity, qtsystems: fix bluetooth support Javier Viguera
2016-01-04 16:17 ` Martin Jansa
2016-01-04 16:39   ` Javier Viguera [this message]
2016-01-04 20:37     ` Martin Jansa
2016-01-05 10:28       ` Javier Viguera
2016-01-12 16:25       ` Javier Viguera
2016-03-01  9:26 ` Javier Viguera
2016-03-01 10:28   ` Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=568AA04B.8000101@digi.com \
    --to=javier.viguera@digi.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox