Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Thornton Ann <ann.thornton@nxp.com>
To: <openembedded-devel@lists.openembedded.org>
Subject: [PATCH][meta-oe] packagegroup-tools-bluetooth: Selects the tools appropriate for the version of bluez being used.
Date: Tue, 10 May 2016 15:25:10 -0500	[thread overview]
Message-ID: <573243A6.5020204@nxp.com> (raw)
In-Reply-To: <1462532454-10125-1-git-send-email-Martin.Jansa@gmail.com>

Thank you, Martin.

Acked by: Ann Thornton <ann.thornton@nxp.com>

-------- Forwarded Message --------
Subject: 	[PATCH][meta-oe] packagegroup-tools-bluetooth: Selects the 
tools appropriate for the version of bluez being used.
Date: 	Fri, 6 May 2016 13:00:54 +0200
From: 	Martin Jansa <martin.jansa@gmail.com>
To: 	openembedded-devel@lists.openembedded.org
CC: 	Ann Thornton <ann.thornton@nxp.com>, Martin Jansa 
<Martin.Jansa@gmail.com>



From: Ann Thornton <ann.thornton@nxp.com>

Signed-off-by: Ann Thornton <ann.thornton@nxp.com>
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
  .../packagegroups/packagegroup-tools-bluetooth.bb  | 43 ++++++++++------------
  1 file changed, 20 insertions(+), 23 deletions(-)

diff --git a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
index bdab389..dde4599 100644
--- a/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
+++ b/meta-oe/recipes-connectivity/packagegroups/packagegroup-tools-bluetooth.bb
@@ -5,36 +5,33 @@ LICENSE = "MIT"
  LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
                      file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
  
-SUMMARY = "Set of Bluetooh related tools for inclusion on images"
-DESCRIPTION = "Add bluetooth tools based on the version of BlueZ in use.\
-The tools that have been tested and work the best are pulled in \
-automatically.  The same packagegroup can be used in a recipe without \
-the need to know which version of BlueZ is in use. \
+SUMMARY = "Set of Bluetooth related tools for inclusion in images"
+DESCRIPTION = "Includes bluetooth specific tools for this version of BlueZ.\
+These tools are used at runtime. \
  Supports BlueZ4 and BlueZ5."
  
  inherit packagegroup
+inherit bluetooth
  
-BLUEZ4_INSTALL = " \
+RDEPENDS_bluez4 = " \
      obexftp \
  "
  
-BLUEZ5_INSTALL = " \
-     bluez5-noinst-tools \
-     bluez5-obex \
-     bluez5-testtools  \
-     libasound-module-bluez \
-     ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', "pulseaudio-module-bluetooth-discover \
-                                                            pulseaudio-module-bluetooth-policy \
-                                                            pulseaudio-module-bluez5-discover \
-                                                            pulseaudio-module-bluez5-device \
-                                                            pulseaudio-module-switch-on-connect \
-                                                            pulseaudio-module-loopback", \
-                                             '', d)} \
+RDEPENDS_bluez5 = " \
+    bluez5-noinst-tools \
+    bluez5-obex \
+    bluez5-testtools  \
+    libasound-module-bluez \
+    ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', \
+        'pulseaudio-module-bluetooth-discover \
+         pulseaudio-module-bluetooth-policy \
+         pulseaudio-module-bluez5-discover \
+         pulseaudio-module-bluez5-device \
+         pulseaudio-module-switch-on-connect \
+         pulseaudio-module-loopback', \
+        '', d)} \
  "
  
-# Install either bluez4 or bluez5 if they are in distro.
+# Install bluez4 tools or bluez5 tools depending on what is specified in the distro.
  # Otherwise install nothing.
-RDEPENDS_${PN} = " \
-     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez5', '${BLUEZ5_INSTALL}', "", d)} \
-     ${@bb.utils.contains('DISTRO_FEATURES', 'bluez4', '${BLUEZ4_INSTALL}', "", d)} \
-"
+RDEPENDS_${PN} = "${RDEPENDS_${BLUEZ}}"
-- 
2.8.2





      reply	other threads:[~2016-05-10 21:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-06 11:00 [PATCH][meta-oe] packagegroup-tools-bluetooth: Selects the tools appropriate for the version of bluez being used Martin Jansa
2016-05-10 20:25 ` Thornton Ann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=573243A6.5020204@nxp.com \
    --to=ann.thornton@nxp.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox