Re: [PATCH 1/3] python-mccabe: Remove pytest

["Yu, Mingli" <mingli.yu@windriver.com>]

On 2016年06月28日 22:55, Tim Orling wrote:
> On Tue, Jun 28, 2016 at 1:36 AM, <mingli.yu@windriver.com> wrote:
>
>> From: Mingli Yu <mingli.yu@windriver.com>
>>
>> * Remove pytest to avoid dependency on python-runner
>>    as only one file test_mccabe.py import pytest and this
>>    test_mccabe.py file not install on our target eventually.
>>
>> That "one file" is where all the tests are housed. Just because you don't
> plan to install the tests on target is no reason to disable testing. If
> anything we need to see more testing of recipes, not less. The solution is
> to add a recipe for the dependency of python-pytest-runner. Then you can
> inherit ptest and package the tests separately.
Thanks! Already update to add python-pytest-runner dependency in new commit.
>
>
>> Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> ---
>>   .../python-mccabe-Remove-pytest.patch              | 32
>> ++++++++++++++++++++++
>>   .../recipes-devtools/python/python-mccabe_0.4.0.bb |  1 +
>>   2 files changed, 33 insertions(+)
>>   create mode 100644
>> meta-python/recipes-devtools/python/python-mccabe/python-mccabe-Remove-pytest.patch
>>
>> diff --git
>> a/meta-python/recipes-devtools/python/python-mccabe/python-mccabe-Remove-pytest.patch
>> b/meta-python/recipes-devtools/python/python-mccabe/python-mccabe-Remove-pytest.patch
>> new file mode 100644
>> index 0000000..ebe70c5
>> --- /dev/null
>> +++
>> b/meta-python/recipes-devtools/python/python-mccabe/python-mccabe-Remove-pytest.patch
>> @@ -0,0 +1,32 @@
>> +From 7c0dc893cd3e57df16cf43d2c51c047997ea5c69 Mon Sep 17 00:00:00 2001
>> +From: Mingli Yu <mingli.yu@windriver.com>
>> +Date: Wed, 22 Jun 2016 02:33:48 +0000
>> +Subject: [PATCH] python-mccabe: Remove pytest
>> +
>> +* Remove pytest to avoid dependency on python-runner
>> +  as only one file test_mccabe.py import pytest and this
>> +  test_mccabe.py file not install on our target eventually.
>> +
>> +Upstream-Status: Inappropriate[oe specific]
>> +
>> +Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
>> +---
>> + setup.py | 2 --
>> + 1 file changed, 2 deletions(-)
>> +
>> +diff --git a/setup.py b/setup.py
>> +index e59903d..64c3ded 100644
>> +--- a/setup.py
>> ++++ b/setup.py
>> +@@ -33,8 +33,6 @@ setup(
>> +     license='Expat license',
>> +     py_modules=['mccabe'],
>> +     zip_safe=False,
>> +-    setup_requires=['pytest-runner'],
>> +-    tests_require=['pytest'],
>> +     entry_points={
>> +         'flake8.extension': [
>> +             'C90 = mccabe:McCabeChecker',
>> +--
>> +2.8.2
>> +
>> diff --git a/meta-python/recipes-devtools/python/python-mccabe_0.4.0.bb
>> b/meta-python/recipes-devtools/python/python-mccabe_0.4.0.bb
>> index 0958f75..1377446 100644
>> --- a/meta-python/recipes-devtools/python/python-mccabe_0.4.0.bb
>> +++ b/meta-python/recipes-devtools/python/python-mccabe_0.4.0.bb
>> @@ -3,6 +3,7 @@ HOMEPAGE = "https://github.com/dreamhost/cliff"
>>   LICENSE = "Apache-2.0"
>>   LIC_FILES_CHKSUM =
>> "file://README.rst;md5=f8b50fba1711ecac6bcdb6324f85a66d"
>>
>> +SRC_URI = "file://python-mccabe-Remove-pytest.patch"
>>   SRC_URI[md5sum] = "8c425db05f310adcd4bb174b991f26f5"
>>   SRC_URI[sha256sum] =
>> "9a2b12ebd876e77c72e41ebf401cc2e7c5b566649d50105ca49822688642207b"
>>
>> --
>> 2.8.1
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>>