Re: [meta-browser] [PATCH] chromium: fix null pointer dereference in V8 with gcc-6

[Andrey Konovalov <andrey.konovalov@linaro.org>]

On 04/11/2017 09:51 PM, Andre McCurdy wrote:
> On Tue, Apr 11, 2017 at 6:02 AM, Andrey Konovalov
> <andrey.konovalov@linaro.org> wrote:
>> On 04/11/2017 03:40 AM, Andre McCurdy wrote:
>>>
>>> On Fri, Apr 7, 2017 at 11:40 AM, Andrey Konovalov
>>> <andrey.konovalov@linaro.org> wrote:
<snip>
>>>> -GYP_DEFINES += "${ARMFPABI}
>>>> release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot=''"
>>>> +GYP_DEFINES += " ${ARMFPABI}
>>>> release_extra_cflags='-Wno-error=unused-local-typedefs' sysroot='' \
>>>> +       ${@bb.utils.contains("AVAILTUNES", "mips", "",
>>>> "release_extra_cflags='-fno-delete-null-pointer-checks'", d)}"
>>>
>>>
>>> What's the significance of skipping the workaround if AVAILTUNES
>>> contains "mips" ?
>>
>>
>> This change (to add '-fno-delete-null-pointer-checks' to gcc flags) was
>> initially merged into chromium directly,
>> but soon reverted as it broke mips somehow:
>> https://bugs.chromium.org/p/v8/issues/detail?id=3782#c10
>
> OK, thanks. Note that building for MIPS isn't currently supported at
> all according to the COMPATIBLE_MACHINE definitions at the top of the
> recipe.

Indeed.
So my check for "mips" in AVAILTUNES is a NOP until someone enables building for MIPS.
Thanks for pointing that out!