Re: [meta-oe][PATCH v2] pm-graph: package the pm-graph files

[Liwei Song <liwei.song@windriver.com>]

On 07/10/2019 10:33 AM, Saini, Naveen Kumar wrote:
> 
> 
> On 7/5/19 10:03 AM, Liwei Song wrote:
>>
>>
>> On 07/05/2019 10:01 AM, Saini, Naveen Kumar wrote:
>>>
>>>
>>> On 7/5/19 9:43 AM, Liwei Song wrote:
>>>> package /usr/lib/pm-grap and /bin/* files created by pm-graph
>>>> to aviod "Files were installed but not shipped in any package"
>>>> error.
>>>>
>>>> Signed-off-by: Liwei Song <liwei.song@windriver.com>
>>>> ---
>>>>    meta-oe/recipes-kernel/pm-graph/pm-graph_5.3.bb | 3 +++
>>>>    1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/meta-oe/recipes-kernel/pm-graph/pm-graph_5.3.bb b/meta-oe/recipes-kernel/pm-graph/pm-graph_5.3.bb
>>>> index ea12e054d3ab..00301298309e 100644
>>>> --- a/meta-oe/recipes-kernel/pm-graph/pm-graph_5.3.bb
>>>> +++ b/meta-oe/recipes-kernel/pm-graph/pm-graph_5.3.bb
>>>> @@ -18,3 +18,6 @@ do_install() {
>>>>    }
>>>>      RDEPENDS_${PN} += "python-core python-threading python-datetime python-subprocess python-compression"
>>>> +
>>>> +FILES_${PN} += "${nonarch_libdir}/pm-graph \
>>> This too not required. Please have a look at
>>> https://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/conf/bitbake.conf
>>>
>>> Could you share your error !
>>
>> The error I got:
>> ERROR: pm-graph-5.3-r0 do_package: QA Issue: pm-graph: Files/directories were installed but not shipped in any package:
>>    /usr/lib
>>    /usr/lib/pm-graph
>>    /usr/lib/pm-graph/sleepgraph.py
>>    /usr/lib/pm-graph/bootgraph.py
>>    /usr/lib/pm-graph/config
>>    /usr/lib/pm-graph/config/cgskip.txt
>>    /usr/lib/pm-graph/config/freeze-callgraph.cfg
>>    /usr/lib/pm-graph/config/freeze.cfg
>>    /usr/lib/pm-graph/config/freeze-dev.cfg
>>    /usr/lib/pm-graph/config/standby-callgraph.cfg
>>    /usr/lib/pm-graph/config/standby.cfg
>>    /usr/lib/pm-graph/config/standby-dev.cfg
>>    /usr/lib/pm-graph/config/suspend-callgraph.cfg
>>    /usr/lib/pm-graph/config/suspend.cfg
>>    /usr/lib/pm-graph/config/suspend-dev.cfg
>>    /usr/lib/pm-graph/config/suspend-x2-proc.cfg
>> Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
>> pm-graph: 16 installed and not shipped files. [installed-vs-shipped]
>> ERROR: pm-graph-5.3-r0 do_package: Fatal QA errors found, failing task.
>> ERROR: pm-graph-5.3-r0 do_package:
>> ERROR: pm-graph-5.3-r0 do_package: Function failed: do_package
> 
> Hmm.. what is ${BASELIB} variable value?
> 
> Are you using latest code?

it's my fault that my code is old without the following patch:
86407337b940 ("pm-graph: fix multilib build failure")

Now it work well.
Sorry to disturb, please ignore this review.

Thanks,
Liwei.


> 
> I do not see this error. Below configuration I am using for multilib build:
> 
> require conf/multilib.conf
> MULTILIBS = "multilib:lib32"
> DEFAULTTUNE_virtclass-multilib-lib32 = "x86"
> 
> 
>>
>>
>> Thanks,
>> Liwei.
>>>> +"
>>>>
>>>
>>>
> 
>