From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mail.openembedded.org (Postfix) with ESMTP id A22C66098F for ; Sat, 15 Jun 2013 12:49:16 +0000 (UTC) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 15 Jun 2013 05:49:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,871,1363158000"; d="scan'208";a="353969557" Received: from unknown (HELO helios.localnet) ([10.252.122.9]) by orsmga002.jf.intel.com with ESMTP; 15 Jun 2013 05:49:16 -0700 From: Paul Eggleton To: "K. Richard Pixley" Date: Sat, 15 Jun 2013 13:49:16 +0100 Message-ID: <6791287.nv6YeJrOrm@helios> Organization: Intel Corporation User-Agent: KMail/4.10.3 (Linux/3.8.0-23-generic; KDE/4.10.3; i686; ; ) In-Reply-To: <51BBBEEE.5080705@noir.com> References: <51BBBEEE.5080705@noir.com> MIME-Version: 1.0 Cc: openembedded-devel@lists.openembedded.org Subject: Re: pseudo fails to compile on rhel-4.7 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Jun 2013 12:49:16 -0000 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday 14 June 2013 18:10:06 K. Richard Pixley wrote: > I know rhel-4.7 is ancient, but the code is broken. > > Looks like the call and the decl don't match. Droping the last param on > the call gets me built. > > --rich > > cc -fno-strict-aliasing -pipe -std=gnu99 -Wall -W -Wextra -fPIC > -D_LARGEFILE64_SOURCE -D_ATFILE_SOURCE > -DPSEUDO_PREFIX='"/home/ericpix/gnu/rhel-4.7"' -DPSEUDO_SUFFIX='""' > -DPSEUDO_BINDIR='"bin"' -DPSEUDO_LIBDIR='"lib"' > -DPSEUDO_LOCALSTATEDIR='"var/pseudo"' -DPSEUDO_VERSION='"1.5.1"' > -DUSE_MEMORY_DB -O2 -g -L/home/ericpix/gnu/rhel-4.7/lib > -I/home/ericpix/gnu/rhel-4.7/include > -Wl,-R/home/ericpix/gnu/rhel-4.7/lib -D_GNU_SOURCE -c -o > pseudo_wrappers.o pseudo_wrappers.c > In file included from ports/linux/oldclone/pseudo_wrappers.c:61, > from port_wrappers.c:23, > from pseudo_wrappers.c:255: > ports/linux/oldclone/guts/clone.c: In function `clone': > ports/linux/oldclone/guts/clone.c:22: error: too many arguments to function > In file included from port_wrappers.c:23, > from pseudo_wrappers.c:255: > ports/linux/oldclone/pseudo_wrappers.c:39: warning: unused variable `tls' > ports/linux/oldclone/pseudo_wrappers.c:40: warning: unused variable `ctid' > pseudo_wrappers.c: At top level: > ports/linux/oldclone/pseudo_wrappers.c:2: warning: unused parameter 'fn' > ports/linux/oldclone/pseudo_wrappers.c:2: warning: unused parameter > 'child_stack' > ports/linux/oldclone/pseudo_wrappers.c:2: warning: unused parameter 'flags' > ports/linux/oldclone/pseudo_wrappers.c:2: warning: unused parameter 'arg' > make: *** [pseudo_wrappers.o] Error 1 > > real 0m0.607s > user 0m0.366s > sys 0m0.103s > ericpix@lx-dev6> lsb_release -a > > LSB Version: > :core-3.0-ia32:core-3.0-noarch:graphics-3.0-ia32:graphics-3.0-noarch > > Distributor ID: RedHatEnterpriseAS > Description: Red Hat Enterprise Linux AS release 4 (Nahant Update 7) > Release: 4 > Codename: NahantUpdate7 > ericpix@lx-dev6> uname -a > Linux lx-dev6 2.6.9-78.ELsmp #1 SMP Wed Jul 9 15:39:47 EDT 2008 i686 > athlon i386 GNU/Linux > > diff --git a/ports/linux/oldclone/guts/clone.c > b/ports/linux/oldclone/guts/clone.c > index 5240bb3..4efe4d8 100644 > --- a/ports/linux/oldclone/guts/clone.c > +++ b/ports/linux/oldclone/guts/clone.c > @@ -19,7 +19,7 @@ > myargs->arg = arg; > > /* call the real syscall */ > - rc = (*real_clone)(wrap_clone_child, child_stack, flags, myargs, > pid); > + rc = (*real_clone)(wrap_clone_child, child_stack, flags, > myargs/* , pid */); > > /* If we're not sharing memory, we need to free myargs in the > parent */ > if (!(flags & CLONE_VM)) > Could you please send this patch to pseudo upstream? Thanks, Paul -- Paul Eggleton Intel Open Source Technology Centre