From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com ([134.134.136.24]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Tn4NO-0007Tx-KQ for openembedded-devel@lists.openembedded.org; Mon, 24 Dec 2012 10:31:17 +0100 Received: from mail-wi0-f197.google.com ([209.85.212.197]) by mga09.intel.com with ESMTP/TLS/RC4-SHA; 24 Dec 2012 01:15:28 -0800 Received: by mail-wi0-f197.google.com with SMTP id hm6so6165094wib.8 for ; Mon, 24 Dec 2012 01:16:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-received:date:from:to:cc:message-id:in-reply-to :references:subject:x-mailer:mime-version:content-type :content-transfer-encoding:content-disposition:x-gm-message-state; bh=h58WyhiQLHBVX8K+zTV74lHOTEs+d0gXN7Iqo3ziee8=; b=P9fgpVPLs8dRsYpniePK0pvbOirEUOPhf0/vQ8DXzV74F0Kovp7JrfCtyQwozu/z0C nJ2ZkX1GrASdpKs6YnnF6LFzsnLDcrHbCC6HB8fQtuaDsx4sLRavxd6OCeI/9tIJAJeq JwA1Ha1rEXiV8kGTf/MaCTZ/hY4zNYMRZjKMQYUvEj1b1syh9pqww0eGtRgCop2fUT7b w0GdgmNPFp5huCKi+Fo1rhu9DqPgIxUiOdtrnM/ReF+8WDl7ITdBUuLlVs0CzcNFAvDg 1MUD4e+sw4UnJYx1jgC6rgNGtijP5NP4EagwySoHGxOy2g60ze5Vqj0w4B/jzZRsf6Um 4FeQ== X-Received: by 10.194.236.68 with SMTP id us4mr34855862wjc.11.1356340581675; Mon, 24 Dec 2012 01:16:21 -0800 (PST) X-Received: by 10.194.236.68 with SMTP id us4mr34855851wjc.11.1356340581553; Mon, 24 Dec 2012 01:16:21 -0800 (PST) Received: from [192.168.1.13] (35.106.2.81.in-addr.arpa. [81.2.106.35]) by mx.google.com with ESMTPS id gz3sm42109066wib.2.2012.12.24.01.16.20 (version=SSLv3 cipher=OTHER); Mon, 24 Dec 2012 01:16:20 -0800 (PST) Date: Mon, 24 Dec 2012 09:16:23 +0000 From: Ross Burton To: Constantin Musca Message-ID: In-Reply-To: <0a47d556f40e643094228fb54e666a3008024aa8.1356337650.git.constantinx.musca@intel.com> References: <0a47d556f40e643094228fb54e666a3008024aa8.1356337650.git.constantinx.musca@intel.com> X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQm2JXYX52Y5S0KRquz1qty0Tyzrq+5irQlApe872mAYkSY7NxZ/O4MYpoYymPtOC/fmHnmNqhpRK0AAKvowOen8/5fuY/LYWnlGuIt8ClK2+zvUyRC4z1rXFm0JhPkgmu2VFhU/H8twPhA9OTDEm/xes6ILTB7L4WLWctnHg12AdnrtUVnKfu2OYY4LuAT1ciub9FRd Cc: OE-devel , openembedded-core@lists.openembedded.org Subject: Re: [OE-core] [PATCH 13/15] metacity: upgrade to 2.34.13 X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Dec 2012 09:31:18 -0000 X-List-Received-Date: Mon, 24 Dec 2012 09:31:18 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline (CCing oe-devel for their opinion) Is anyone actually using metacity? Nothing in oe-core uses it so maybe we should move it to meta-gnome, or just drop it if meta-gnome wants to push on towards Gnome 3? Ross On Monday, 24 December 2012 at 08:34, Constantin Musca wrote: > crosscompile.patch: removed > - schema_bindings binary not generated anymore > > remove-yelp-help-rules-var.patch: added > - YELP_HELP_RULES var is not used > > [Other changes] > - the 2.34.13 version requires the gsettings-desktop-schemas > (add it to DEPENDS) > > Signed-off-by: Constantin Musca > --- > .../gnome/metacity/crosscompile.patch | 62 ---------------------- > .../metacity/remove-yelp-help-rules-var.patch | 28 ++++++++++ > .../{metacity_2.30.3.bb => metacity_2.34.13.bb} | 14 ++--- > 3 files changed, 35 insertions(+), 69 deletions(-) > delete mode 100644 meta/recipes-gnome/gnome/metacity/crosscompile.patch > create mode 100644 meta/recipes-gnome/gnome/metacity/remove-yelp-help-rules-var.patch > rename meta/recipes-gnome/gnome/{metacity_2.30.3.bb => metacity_2.34.13.bb} (56%) > > diff --git a/meta/recipes-gnome/gnome/metacity/crosscompile.patch b/meta/recipes-gnome/gnome/metacity/crosscompile.patch > deleted file mode 100644 > index 7a1942a..0000000 > --- a/meta/recipes-gnome/gnome/metacity/crosscompile.patch > +++ /dev/null > @@ -1,62 +0,0 @@ > -This patch is revised version from openembed. It build host native binary > -rather than target binary in cross-compile environment. > - > -Signed-off-by: Zhai Edwin > - > -Upstream-Status: Inappropriate [embedded specific] > - > -Index: metacity-2.30.3/src/Makefile.am > -=================================================================== > ---- metacity-2.30.3.orig/src/Makefile.am 2010-09-05 00:09:52.000000000 +0800 > -+++ metacity-2.30.3/src/Makefile.am 2010-12-31 11:15:31.000000000 +0800 > -@@ -134,11 +134,9 @@ > - metacity_theme_viewer_SOURCES= \ > - ui/theme-viewer.c > - > --schema_bindings_SOURCES = \ > -- core/schema-bindings.c \ > -- metacity.schemas.in.in (http://metacity.schemas.in.in) > -+schema_bindings: > -+ @CC_FOR_BUILD@ core/schema-bindings.c -I./include -I../ @CFLAGS_FOR_BUILD@ @LDFLAGS_FOR_BUILD@ -o schema_bindings > - > --schema_bindings_LDADD = @METACITY_LIBS@ > - metacity.schemas.in (http://metacity.schemas.in): schema_bindings ${srcdir}/metacity.schemas.in.in (http://metacity.schemas.in.in) > - @echo Generating keybinding schemas... ${srcdir}/metacity.schemas.in.in (http://metacity.schemas.in.in) > - ${builddir}/schema_bindings ${srcdir}/metacity.schemas.in.in (http://metacity.schemas.in.in) ${builddir}/metacity.schemas.in (http://metacity.schemas.in) > -Index: metacity-2.30.3/configure.in > -=================================================================== > ---- metacity-2.30.3.orig/configure.in 2010-09-22 22:14:06.000000000 +0800 > -+++ metacity-2.30.3/configure.in 2010-12-31 11:15:31.000000000 +0800 > -@@ -31,6 +31,32 @@ > - AC_LIBTOOL_WIN32_DLL > - AM_PROG_LIBTOOL > - > -+if test x"$CC_FOR_BUILD" = x; then > -+ if test x"$cross_compiling" = xyes; then > -+ AC_CHECK_PROGS(CC_FOR_BUILD, gcc cc) > -+ else > -+ CC_FOR_BUILD="$CC" > -+ fi > -+fi > -+AC_SUBST([CC_FOR_BUILD]) > -+if test x"$CFLAGS_FOR_BUILD" = x; then > -+ if test x"$cross_compiling" = xyes; then > -+ echo boo! > -+ else > -+ CFLAGS_FOR_BUILD="$CFLAGS" > -+ fi > -+fi > -+AC_SUBST([CFLAGS_FOR_BUILD]) > -+if test x"$LDFLAGS_FOR_BUILD" = x; then > -+ if test x"$cross_compiling" = xyes; then > -+ echo boo! > -+ else > -+ LDFLAGS_FOR_BUILD="$LDFLAGS" > -+ fi > -+fi > -+AC_SUBST([LDFLAGS_FOR_BUILD]) > -+ > -+ > - #### Integer sizes > - > - AC_CHECK_SIZEOF(char) > diff --git a/meta/recipes-gnome/gnome/metacity/remove-yelp-help-rules-var.patch b/meta/recipes-gnome/gnome/metacity/remove-yelp-help-rules-var.patch > new file mode 100644 > index 0000000..1970e9a > --- /dev/null > +++ b/meta/recipes-gnome/gnome/metacity/remove-yelp-help-rules-var.patch > @@ -0,0 +1,28 @@ > +Remove unused variable (YELP_HELP_RULES) > + > +Upstream-Status: Pending > +Signed-off-by: Constantin Musca > + > +Index: metacity-2.34.13/doc/creating_themes/Makefile.am > +=================================================================== > +--- metacity-2.34.13.orig/doc/creating_themes/Makefile.am > ++++ metacity-2.34.13/doc/creating_themes/Makefile.am > +@@ -1,6 +1,5 @@ > + ### This part of Makefile.am (http://Makefile.am) can be customized by you. > + > +-@YELP_HELP_RULES@ > + > + # The name of the directory in /usr/share/gnome/help/, > + # and the name of the main .xml file: > +Index: metacity-2.34.13/doc/creating_themes/Makefile.in > +=================================================================== > +--- metacity-2.34.13.orig/doc/creating_themes/Makefile.in > ++++ metacity-2.34.13/doc/creating_themes/Makefile.in > +@@ -455,7 +455,6 @@ uninstall-am: > + mostlyclean-libtool pdf pdf-am ps ps-am uninstall uninstall-am > + > + > +-@YELP_HELP_RULES@ > + > + # Tell versions [3.59,3.63) of GNU make to not export all variables. > + # Otherwise a system limit (for SysV at least) may be exceeded. > diff --git a/meta/recipes-gnome/gnome/metacity_2.30.3.bb b/meta/recipes-gnome/gnome/metacity_2.34.13.bb > similarity index 56% > rename from meta/recipes-gnome/gnome/metacity_2.30.3.bb > rename to meta/recipes-gnome/gnome/metacity_2.34.13.bb > index 5b996d2..3605201 100644 > --- a/meta/recipes-gnome/gnome/metacity_2.30.3.bb > +++ b/meta/recipes-gnome/gnome/metacity_2.34.13.bb > @@ -4,14 +4,16 @@ LICENSE = "GPLv2+" > LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \ > file://src/include/main.h;endline=24;md5=c2242df552c880280315989bab626b90" > > -DEPENDS = "startup-notification gtk+ gconf gdk-pixbuf-native libcanberra gnome-doc-utils" > -PR = "r5" > +DEPENDS = "gsettings-desktop-schemas startup-notification gtk+ gconf gdk-pixbuf-native libcanberra gnome-doc-utils" > +PR = "r0" > > inherit gnome update-alternatives > > -SRC_URI += "file://crosscompile.patch" > -SRC_URI[archive.md5sum] = "553784f376d96b902e19ff437cd5b339" > -SRC_URI[archive.sha256sum] = "08f887018fa5e447cf184d03bae3fe2c05fdb7583bed6768e3b4d66392fc18dd" > +GNOME_COMPRESS_TYPE = "xz" > + > +SRC_URI += "file://remove-yelp-help-rules-var.patch" > +SRC_URI[archive.md5sum] = "6d89b71672d4fa49fc87f83d610d0ef6" > +SRC_URI[archive.sha256sum] = "8cf4dbf0da0a6f36357ce7db7f829ec685908a7792453c662fb8184572b91075" > > ALTERNATIVE_${PN} = "x-window-manager" > ALTERNATIVE_TARGET[x-window-manager] = "${bindir}/metacity" > @@ -23,8 +25,6 @@ EXTRA_OECONF += "--disable-verbose \ > do_configure_prepend() { > sed -i -e 's:$ZENITY:$NOZENITY:g' -e 's:-Werror::g' ${S}/configure.in (http://configure.in) > } > -CFLAGS_FOR_BUILD += "-I${STAGING_LIBDIR_NATIVE}/glib-2.0/include -I${STAGING_INCDIR_NATIVE}/glib-2.0 -I${STAGING_INCDIR_NATIVE}/glib-2.0/include -I${STAGING_INCDIR_NATIVE}" > -LDFLAGS_FOR_BUILD += "-L${STAGING_LIBDIR_NATIVE} -lglib-2.0" > > FILES_${PN} += "${datadir}/themes ${datadir}/gnome-control-center ${datadir}/gnome" > > -- > 1.7.11.7 > > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org (mailto:Openembedded-core@lists.openembedded.org) > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core