From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB75ED3C927 for ; Sun, 20 Oct 2024 03:58:27 +0000 (UTC) Received: from mailout06.t-online.de (mailout06.t-online.de [194.25.134.19]) by mx.groups.io with SMTP id smtpd.web11.18755.1729396706978015226 for ; Sat, 19 Oct 2024 20:58:27 -0700 Authentication-Results: mx.groups.io; dkim=none (message not signed); spf=pass (domain: t-online.de, ip: 194.25.134.19, mailfrom: f_l_k@t-online.de) Received: from fwd83.aul.t-online.de (fwd83.aul.t-online.de [10.223.144.109]) by mailout06.t-online.de (Postfix) with SMTP id 33B0F2A1A5; Sun, 20 Oct 2024 05:58:25 +0200 (CEST) Received: from [192.168.178.67] ([84.154.175.81]) by fwd83.t-online.de with (TLSv1.3:TLS_AES_256_GCM_SHA384 encrypted) esmtp id 1t2N5E-214VBg0; Sun, 20 Oct 2024 05:58:25 +0200 Date: Sun, 20 Oct 2024 06:00:28 +0200 From: Markus Volk Subject: Re: [oe] [meta-oe][PATCH] snapper: add recipe To: Khem Raj Cc: openembedded-devel@lists.openembedded.org Message-Id: In-Reply-To: References: <20241018131724.3051-1-f_l_k@t-online.de> X-Mailer: geary/46.0 MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="=-0kQ9vzamGjoX2U0qVo1J" X-TOI-EXPURGATEID: 150726::1729396705-257F85DD-C5744FD0/0/0 CLEAN NORMAL X-TOI-MSGID: e511ea0c-668d-483e-999b-38cd4ed4e538 List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Sun, 20 Oct 2024 03:58:27 -0000 X-Groupsio-URL: https://lists.openembedded.org/g/openembedded-devel/message/113066 --=-0kQ9vzamGjoX2U0qVo1J Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable The problem has already been fixed in Alpine Linux. Added a patch found=20 there Additionally, I also added dependencies for e2fsprogs and ncurses,=20 since snapper links to -ltinfo and a runtime dependency of=20 util-linux-mount On Sat, Oct 19 2024 at 06:40:56 PM -07:00:00, Khem Raj=20 wrote: > On Fri, Oct 18, 2024 at 9:23=E2=80=AFAM Khem Raj > wrote: >>=20 >> On Fri, Oct 18, 2024 at 6:15=E2=80=AFAM Markus Volk via=20 >> lists.openembedded.org >> > > wrote: >> > >> > Snapper is a tool for Linux file system snapshot management.=20 >> Apart from >> > the obvious creation and deletion of snapshots it can compare=20 >> snapshots >> > and revert differences between them. In simple terms, this allows=20 >> root >> > and non-root users to view older versions of files and revert=20 >> changes. >> > >> > Signed-off-by: Markus Volk > > >> > --- >> > .../recipes-support/snapper/snapper_0.11.2.bb | 35=20 >> +++++++++++++++++++ >> > 1 file changed, 35 insertions(+) >> > create mode 100644=20 >> meta-oe/recipes-support/snapper/snapper_0.11.2.bb >> > >> > diff --git a/meta-oe/recipes-support/snapper/snapper_0.11.2.bb=20 >> b/meta-oe/recipes-support/snapper/snapper_0.11.2.bb >> > new file mode 100644 >> > index 000000000..2759cdafb >> > --- /dev/null >> > +++ b/meta-oe/recipes-support/snapper/snapper_0.11.2.bb >> > @@ -0,0 +1,35 @@ >> > +SUMMARY =3D "Snapper is a tool for Linux file system snapshot=20 >> management" >> > +HOMEPAGE =3D "" >> > +LICENSE =3D "GPL-2.0-only" >> > +LIC_FILES_CHKSUM =3D=20 >> "file://COPYING;md5=3D751419260aa954499f7abaabaa882bbe"=20 >> >> > + >> > +DEPENDS =3D "acl boost btrfs-tools dbus json-c libxml2 lvm2 zlib" >> > + >> > +# Build separation is slightly broken >> > +inherit autotools-brokensep pkgconfig gettext >> > + >> > +SRC_URI =3D=20 >> "git://github.com/openSUSE/snapper.git;protocol=3Dhttps;branch=3Dmaster" >> > +SRCREV =3D "6c603565f36e9996d85045c8012cd04aba5f3708" >> > + >> > +S =3D "${WORKDIR}/git" >> > + >> > +PACKAGECONFIG ?=3D "${@bb.utils.filter=20 >> ('DISTRO_FEATURES', 'api-documentation=20 >> systemd pam', d)}" >> > +PACKAGECONFIG[pam] =3D "--enable-pam,--disable-pam,libpam" >> > +PACKAGECONFIG[systemd] =3D "--enable-systemd,--disable-systemd" >> > +PACKAGECONFIG[api-documentation] =3D=20 >> "--enable-doc,--disable-doc,libxslt-native=20 >> docbook-xsl-stylesheets-native" >> > + >> > +# Avoid HOSTTOOLS path in binaries >> > +export DIFFBIN=3D"${bindir}/diff" >> > +export RMBIN =3D "${bindir}/rm" >> > +export TOUCHBIN =3D "${bindir}/touch" >> > +export CPBIN =3D "${bindir}/cp" >> > + >> > + >> > +do_install:append() { >> > + install -d ${D}${sysconfdir}/sysconfig >> > + install -m0644 ${S}/data/default-config=20 >> ${D}${sysconfdir}/sysconfig/snapper >> > +} >> > + >> > +FILES:${PN} +=3D "${libdir}/pam_snapper ${libdir}/systemd=20 >> ${libdir}/zypp ${libdir}/security ${datadir}" >> > +# bash is needed for the testsuite >> > +RDEPENDS:${PN} =3D "bash diffutils util-linux" >>=20 >> It would be good to package test binary and resources into=20 >> ${PN}-ptest package >> and then attach the needed rdeps to ${PN}-ptest package also look=20 >> into >> inheriting >> ptest class which should provide a basic build block for adding=20 >> ptests. >>=20 >=20 > it fails to build with musl see > >=20 > stavfs64 is not needed if we are already using LFS64, we can just use > statvfs even on glibc > otherwise add -D_LARGEFILE64_SOURCE with musl builds to cflags >=20 >> > -- >> > 2.47.0 >> > >> > >> > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- >> > Links: You receive all messages sent to this group. >> > View/Reply Online (#112978):=20 >> >> > Mute This Topic:=20 >> >> > Group Owner: openembedded-devel+owner@lists.openembedded.org=20 >> >> > Unsubscribe:=20 >> =20 >> [raj.khem@gmail.com ] >> > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- >> > --=-0kQ9vzamGjoX2U0qVo1J Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The problem has already been fixed= in Alpine Linux. Added a patch found there

Additi= onally, I also added dependencies for e2fsprogs and ncurses, since snapper = links to -ltinfo and a runtime dependency of util-linux-mount

On Sat, Oct 19 2024 at 06:40:56 PM -= 07:00:00, Khem Raj <raj.khem@gmail.com> wrote:
On Fri= , Oct 18, 2024 at 9:23=E2=80=AFAM Khem Raj <raj.khem@gmail.com> wrote:
On Fri, Oct 18, 2024 at 6:15=E2=80=AFAM Markus Volk via lists.openembedded= .org <f_l_k=3D= t-online.de@lists.openembedded.org> wrote: > > Snapper is a tool for Linux file system snapshot management. Apart fr= om > the obvious creation and deletion of snapshots it can compare snapsho= ts > and revert differences between them. In simple terms, this allows roo= t > and non-root users to view older versions of files and revert changes= . > > Signed-off-by: Markus Volk <f= _l_k@t-online.de> > --- > .../recipes-support/snapper/snapper_0.11.2.bb | 35 +++++++++++++++++= ++ > 1 file changed, 35 insertions(+) > create mode 100644 meta-oe/recipes-support/snapper/snapper_0.11.2.bb > > diff --git a/meta-oe/recipes-support/snapper/snapper_0.11.2.bb b/meta= -oe/recipes-support/snapper/snapper_0.11.2.bb > new file mode 100644 > index 000000000..2759cdafb > --- /dev/null > +++ b/meta-oe/recipes-support/snapper/snapper_0.11.2.bb > @@ -0,0 +1,35 @@ > +SUMMARY =3D "Snapper is a tool for Linux file system snapshot manage= ment" > +HOMEPAGE =3D "https:= //github.com/openSUSE/snapper" > +LICENSE =3D "GPL-2.0-only" > +LIC_FILES_CHKSUM =3D "file://COPYING;md5=3D751419260aa954499f7abaabaa8= 82bbe" > + > +DEPENDS =3D "acl boost btrfs-tools dbus json-c libxml2 lvm2 zlib" > + > +# Build separation is slightly broken > +inherit autotools-brokensep pkgconfig gettext > + > +SRC_URI =3D "git://github.com/openSUSE/snapper.git;protocol=3Dhttps;= branch=3Dmaster" > +SRCREV =3D "6c603565f36e9996d85045c8012cd04aba5f3708" > + > +S =3D "${WORKDIR}/git" > + > +PACKAGECONFIG ?=3D "${@bb.util= s.filter('DISTRO_FEATURES', 'api-documentation systemd pam', d)}" > +PACKAGECONFIG[pam] =3D "--enable-pam,--disable-pam,libpam" > +PACKAGECONFIG[systemd] =3D "--enable-systemd,--disable-systemd" > +PACKAGECONFIG[api-documentation] =3D "--enable-doc,--disable-doc,lib= xslt-native docbook-xsl-stylesheets-native" > + > +# Avoid HOSTTOOLS path in binaries > +export DIFFBIN=3D"${bindir}/diff" > +export RMBIN =3D "${bindir}/rm" > +export TOUCHBIN =3D "${bindir}/touch" > +export CPBIN =3D "${bindir}/cp" > + > + > +do_install:append() { > + install -d ${D}${sysconfdir}/sysconfig > + install -m0644 ${S}/data/default-config ${D}${sysconfdir}/sys= config/snapper > +} > + > +FILES:${PN} +=3D "${libdir}/pam_snapper ${libdir}/systemd ${libdir}/= zypp ${libdir}/security ${datadir}" > +# bash is needed for the testsuite > +RDEPENDS:${PN} =3D "bash diffutils util-linux" It would be good to package test binary and resources into ${PN}-ptest pac= kage and then attach the needed rdeps to ${PN}-ptest package also look into inheriting ptest class which should provide a basic build block for adding ptests.
it fails to build with musl see https://= errors.yoctoproject.org/Errors/Details/809996/ stavfs64 is not needed if we are already using LFS64, we can just use statvfs even on glibc otherwise add -D_LARGEFILE64_SOURCE with musl builds to cflags
> -- > 2.47.0 > > > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- > Links: You receive all messages sent to this group. > View/Reply Online (#112978): https://lists.openembedded.org/g/ope= nembedded-devel/message/112978 > Mute This Topic: https://lists.openembedded.org/mt/109081580/1997914 > Group Owner: openembedded-devel+owner@lists.openembedded.org > Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub= [raj.khem@gmail.com] > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- >
--=-0kQ9vzamGjoX2U0qVo1J--