Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "Adam C. Foltzer" <acfoltzer@galois.com>
Cc: "openembedded-devel@lists.openembedded.org"
	<openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH 3/3] meson: add LDFLAGS to bbclass C/C++ link	arguments
Date: Wed, 7 Jun 2017 21:48:48 +0000	[thread overview]
Message-ID: <a96952a133614ffc9779d8a7ce912f8e@XBOX02.axis.com> (raw)
In-Reply-To: <20170605172321.12557-3-acfoltzer@galois.com>

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Adam C. Foltzer
> Sent: den 5 juni 2017 19:23
> To: openembedded-devel@lists.openembedded.org
> Subject: [oe] [meta-oe][PATCH 3/3] meson: add LDFLAGS to bbclass C/C++
> link arguments
> 
> This adds compiler flags for C++ projects, and fixes the linker
> arguments for both C and C++ to avoid the GNU_HASH qa failure
> 
> Signed-off-by: Adam C. Foltzer <acfoltzer@galois.com>
> ---
>  meta-oe/classes/meson.bbclass | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/meta-oe/classes/meson.bbclass b/meta-
> oe/classes/meson.bbclass
> index d2ae626..11c8d34 100644
> --- a/meta-oe/classes/meson.bbclass
> +++ b/meta-oe/classes/meson.bbclass
> @@ -32,7 +32,8 @@ MESONOPTS = " --prefix ${prefix} \
>                --localstatedir ${localstatedir} \
>                --sharedstatedir ${sharedstatedir}"
> 
> -MESON_C_ARGS = "${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}"
> +MESON_C_ARGS = "${TARGET_CC_ARCH}${TOOLCHAIN_OPTIONS}"
> +MESON_LINK_ARGS = "${TOOLCHAIN_OPTIONS} ${LDFLAGS}"

According to a colleague of mine, the ${TARGET_CC_ARCH} options need 
to be passed to the linker as well or binaries end up with the wrong 
ld.so for armhf.

Also, why do you need to add ${LDFLAGS} here?

>  MESON_HOST_ENDIAN = "${@bb.utils.contains('SITEINFO_ENDIANNESS', 'be',
> 'big', 'little', d)}"
>  MESON_TARGET_ENDIAN = "${@bb.utils.contains('TUNE_FEATURES',
> 'bigendian', 'big', 'little', d)}"
> @@ -61,9 +62,9 @@ pkgconfig = 'pkg-config'
> 
>  [properties]
>  c_args = [${@meson_array('MESON_C_ARGS', d)}]
> -cpp_args = [${@meson_array('TOOLCHAIN_OPTIONS', d)}]
> -c_link_args = [${@meson_array('TOOLCHAIN_OPTIONS', d)}]
> -cpp_link_args = [${@meson_array('TOOLCHAIN_OPTIONS', d)}]
> +c_link_args = [${@meson_array('MESON_LINK_ARGS', d)}]
> +cpp_args = [${@meson_array('MESON_C_ARGS', d)}]
> +cpp_link_args = [${@meson_array('MESON_LINK_ARGS', d)}]
> 
>  [host_machine]
>  system = '${BUILD_OS}'
> --
> 2.9.4

//Peter



  reply	other threads:[~2017-06-07 21:48 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 17:23 [meta-oe][PATCH 1/3] meson: update Meson devtool to 0.40.1 Adam C. Foltzer
2017-06-05 17:23 ` [meta-oe][PATCH 2/3] meson: fix build/host confusion for bbclass Adam C. Foltzer
2017-06-16 11:19   ` Linus Svensson
2017-06-26 13:07     ` Burton, Ross
2017-06-05 17:23 ` [meta-oe][PATCH 3/3] meson: add LDFLAGS to bbclass C/C++ link arguments Adam C. Foltzer
2017-06-07 21:48   ` Peter Kjellerstedt [this message]
2017-06-08 17:34     ` [meta-oe][PATCH v2] meson: add LDFLAGS to bbclass C/C++ link Adam C. Foltzer
2017-06-08 17:34       ` [meta-oe][PATCH v2] meson: add LDFLAGS to bbclass C/C++ link arguments Adam C. Foltzer
2017-06-08 17:44         ` Khem Raj
2017-06-08 17:50           ` Adam Foltzer
2017-06-26 12:58         ` Burton, Ross
2017-06-07 21:44 ` [meta-oe][PATCH 1/3] meson: update Meson devtool to 0.40.1 Peter Kjellerstedt
2017-06-09  8:43   ` -pie in SECURITY_CFLAGS (was: Re: [meta-oe][PATCH 1/3] meson: update Meson devtool to 0.40.1) Patrick Ohly
2017-06-09 13:24     ` Khem Raj
2017-06-09 14:34       ` Patrick Ohly
2017-06-09 17:32         ` Patrick Ohly
2017-06-12  7:04           ` Patrick Ohly
2017-06-12 14:47             ` Khem Raj
2017-06-12 18:23               ` Peter Kjellerstedt
2017-06-12 18:50                 ` Khem Raj
2017-06-08 19:47 ` [meta-oe][PATCH 1/3] meson: update Meson devtool to 0.40.1 Martin Jansa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a96952a133614ffc9779d8a7ce912f8e@XBOX02.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=acfoltzer@galois.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox