Re: [oe] [dunfel 03/32] jsoncpp: upgrade 1.9.2 -> 1.9.3

["Khem Raj" <raj.khem@gmail.com>]

On 7/9/20 9:48 AM, Martin Jansa wrote:
> I don't have a strong opinion about this one.
> 
> It's easy enough to undo by downstream layers if they care about ABI.
> 
> At LGE we do have some prebuilt binaries which use jsoncpp, so we do
> care, but haven't updated to dunfell yet and when we do get those
> prebuilt binaries to be rebuilt, we might as well use newer jsoncpp (and
> in that case might backport this upgrade anyway even if it gets reverted
> in dunfell).
> 
> Maybe someone else will share an opinion on this as well.

I checked https://github.com/open-source-parsers/jsoncpp/releases/tag/1.9.3

and it does not mention ABI change there from 1.9.2 to 1.9.3

but then I see

https://github.com/open-source-parsers/jsoncpp/commit/8b7ea09b8055df01866a5ce4142b12ed8f9f13eb

I dont know if there are API changes which means it will need porting
effors for users or is it just a relinking that is needed.

> 
> On Thu, Jul 9, 2020 at 6:06 PM akuster808 <akuster808@gmail.com
> <mailto:akuster808@gmail.com>> wrote:
> 
> 
> 
>     On 7/9/20 8:21 AM, Martin Jansa wrote:
>>     FYI this "small" upgrade changes ABI version from libjsoncpp22
>>     to libjsoncpp24 which might cause some issues to people who expect
>>     relatively stable ABIs in LTS dunfell.
> 
>     Well that is not good. I did look at the details but apparently I
>     failed to catch the "soversion" change.
> 
>     Would you recommend reverting this?
> 
>     -armin
>>
>>     On Wed, Jul 1, 2020 at 2:07 AM akuster <akuster808@gmail.com
>>     <mailto:akuster808@gmail.com>> wrote:
>>
>>         From: Pierre-Jean Texier <pjtexier@koncepto.io
>>         <mailto:pjtexier@koncepto.io>>
>>
>>         See full changelog
>>         https://github.com/open-source-parsers/jsoncpp/releases/tag/1.9.3
>>
>>         Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io
>>         <mailto:pjtexier@koncepto.io>>
>>         Signed-off-by: Khem Raj <raj.khem@gmail.com
>>         <mailto:raj.khem@gmail.com>>
>>         (cherry picked from commit
>>         65e124eef373680726ac045677cbec7d9080a289)
>>         Signed-off-by: Armin Kuster <akuster808@gmail.com
>>         <mailto:akuster808@gmail.com>>
>>         ---
>>          .../jsoncpp/{jsoncpp_1.9.2.bb <http://jsoncpp_1.9.2.bb> =>
>>         jsoncpp_1.9.3.bb <http://jsoncpp_1.9.3.bb>}              | 2 +-
>>          1 file changed, 1 insertion(+), 1 deletion(-)
>>          rename meta-oe/recipes-devtools/jsoncpp/{jsoncpp_1.9.2.bb
>>         <http://jsoncpp_1.9.2.bb> => jsoncpp_1.9.3.bb
>>         <http://jsoncpp_1.9.3.bb>} (93%)
>>
>>         diff --git a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.2.bb
>>         <http://jsoncpp_1.9.2.bb>
>>         b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>         <http://jsoncpp_1.9.3.bb>
>>         similarity index 93%
>>         rename from meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.2.bb
>>         <http://jsoncpp_1.9.2.bb>
>>         rename to meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>         <http://jsoncpp_1.9.3.bb>
>>         index a88410f2ff..97c6361ad8 100644
>>         --- a/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.2.bb
>>         <http://jsoncpp_1.9.2.bb>
>>         +++ b/meta-oe/recipes-devtools/jsoncpp/jsoncpp_1.9.3.bb
>>         <http://jsoncpp_1.9.3.bb>
>>         @@ -11,7 +11,7 @@ SECTION = "libs"
>>          LICENSE = "MIT"
>>          LIC_FILES_CHKSUM =
>>         "file://LICENSE;md5=fa2a23dd1dc6c139f35105379d76df2b"
>>
>>         -SRCREV = "d2e6a971f4544c55b8e3b25cf96db266971b778f"
>>         +SRCREV = "6aba23f4a8628d599a9ef7fa4811c4ff6e4070e2"
>>          SRC_URI = "git://github.com/open-source-parsers/jsoncpp
>>         <http://github.com/open-source-parsers/jsoncpp>"
>>
>>          S = "${WORKDIR}/git"
>>         -- 
>>         2.17.1
>>
>>
> 
> 
> 
>