From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: OpenEmbedded Development mailing list
<openembedded-devel@lists.openembedded.org>
Subject: scripts/runqemu-internal adds "-no-reboot" QEMU options redundantly
Date: Sat, 12 Jul 2014 07:51:53 -0400 (EDT) [thread overview]
Message-ID: <alpine.LFD.2.11.1407120746570.23730@localhost> (raw)
more obsessive pedantry, but when i do "runqemu qemuarm" (or other
arches), i notice that the eventual lengthy "qemu-system-arm" command
run has the option "-no-reboot" in it twice. that's because, in
scripts/runqemu-internal, numerous individual architectures add that
option to the variable QEMUOPTIONS while, at the bottom of that
script, one reads:
echo "Running $QEMU..."
# -no-reboot is a mandatory option - see bug #100
if [ "$FSTYPE" = "vmdk" ]; then
echo $QEMUBIN $VM $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT
... snip ...
wherein everyone ends up including that option a second time.
doesn't hurt, of course, but it makes reading that script more
confusing than it has to be.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
reply other threads:[~2014-07-12 11:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1407120746570.23730@localhost \
--to=rpjday@crashcourse.ca \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox