Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: "Robert P. J. Day" <rpjday@crashcourse.ca>
To: OpenEmbedded Development mailing list
	<openembedded-devel@lists.openembedded.org>
Subject: missing trailing spaces in some "_prepend" expressions in oe-core
Date: Mon, 5 Jan 2015 09:58:01 -0500 (EST)	[thread overview]
Message-ID: <alpine.LFD.2.11.1501050948080.16705@localhost> (raw)


  after running across a variable "_prepend" assignment that had no
trailing space, i did a quick grep through oe-core and ran across the
following, which would all seem to need that trailing space:

$ grep -rn "DEPENDS_prepend.*[^ ]\"$" *
meta/classes/qt4e.bbclass:2:DEPENDS_prepend = "${QT4EDEPENDS}"
meta/classes/cpan_build.bbclass:27:DEPENDS_prepend = "${@cpan_build_dep_prepend(d)}"
meta/classes/autotools.bbclass:24:DEPENDS_prepend = "${@autotools_dep_prepend(d)}"
meta/classes/qt4x11.bbclass:2:DEPENDS_prepend = "${QT4DEPENDS}"
$

and

$ grep -rn "SRC_URI_prepend.*[^ ]\"$" *
meta/recipes-devtools/qemu/qemu_git.bb:10:SRC_URI_prepend = "git://git.qemu.org/qemu.git"
meta/recipes-devtools/qemu/qemu_2.2.0.bb:10:SRC_URI_prepend = "http://wiki.qemu-project.org/download/${BP}.tar.bz2"
$

  there may be more, i just left it at that, not sure if there's
something magic about those examples or whether they really should
have the space added, so i'll leave it with someone else to tweak.

rday

p.s. is there any difference between appending or prepending to the
list of build-time dependencies in "DEPENDS"? most extensions to
"DEPENDS" i've seen use "_append", but occasionally, i see "_prepend".
does it matter?

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================


             reply	other threads:[~2015-01-05 16:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 14:58 Robert P. J. Day [this message]
2015-01-05 16:25 ` missing trailing spaces in some "_prepend" expressions in oe-core Martin Jansa
2015-01-09 12:57   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.11.1501050948080.16705@localhost \
    --to=rpjday@crashcourse.ca \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox