Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: Khem Raj <raj.khem@gmail.com>,
	Trevor Woerner <twoerner@gmail.com>,
	"Andre McCurdy" <armccurdy@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
Subject: Re: [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package
Date: Sat, 19 May 2018 11:59:33 +0000	[thread overview]
Message-ID: <c7fbbf37e1ff4631a0aa3b45c07544a9@XBOX02.axis.com> (raw)
In-Reply-To: <3f41b911-4fde-1ed1-76f7-650dab5dbb20@gmail.com>

> -----Original Message-----
> From: openembedded-devel-bounces@lists.openembedded.org
> [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf Of
> Khem Raj
> Sent: den 19 maj 2018 06:53
> To: Trevor Woerner <twoerner@gmail.com>; Andre McCurdy
> <armccurdy@gmail.com>
> Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>
> Subject: Re: [oe] [meta-oe][PATCH 01/17] libwebsockets: rely on
> cmake.bbclass to put cmake package files in dev package
> 
> On 5/18/18 7:37 PM, Trevor Woerner wrote:
> > On Fri, May 18, 2018 at 6:28 PM, Andre McCurdy <armccurdy@gmail.com
> > <mailto:armccurdy@gmail.com>> wrote:
> >
> >     On Fri, May 18, 2018 at 2:01 PM, Khem Raj <raj.khem@gmail.com
> >     <mailto:raj.khem@gmail.com>> wrote:
> >     > On Fri, May 18, 2018 at 12:07 PM, Andre McCurdy
> <armccurdy@gmail.com <mailto:armccurdy@gmail.com>> wrote:
> >     >> On Thu, May 17, 2018 at 6:56 PM, Khem Raj <raj.khem@gmail.com
> <mailto:raj.khem@gmail.com>> wrote:
> >     >>> Hi Andre
> >     >>>
> >     >>> This series is fine, except that it has some formatting
> changes mixed with
> >     >>> cmake related changes. It would be preferable to have them as
> separate
> >     >>> pulls. I reckon that both types of changes are good.
> >     >>
> >     >> The formatting cleanups are all minor and probably not worth
> >     >> submitting on their own.
> >     >>
> >     >
> >     > OK thats fine, drop then in v2
> >
> >     They are not worth reworking the patch set to create a v2 either
> :-)
> >
> >
> > It would be wonderful if we could agree on formatting; if we could,
> I'd
> > certainly help by taking on some of the reformatting task.
> >
> > Unfortunately, all such past attempts of which I'm aware never got
> > anywhere, and if I remember correctly, the Yocto folks and the OE
> folks
> > each have their own ideas of what is "correct".
> >
> > In any case, if these won't get in as is, if Andre doesn't want to
> spin
> > a v2 without the formatting changes, and everyone is okay with it, I
> > could spin a v2 without the formatting changes.
> 
> Please do.

If you do, I think you should spin the patches for the clean ups as well. 
At least I agree with (most) of them, and on a whole they definitely 
improve the recipes.

And I also agree with Andre, that in general it is too much trouble to 
generate clean up patches in their own, which is why it might be better 
to allow some clean ups together with actual changes. Otherwise they will 
not happen, which in the long run deteriorate the overall state of the 
recipes.

//Peter



  reply	other threads:[~2018-05-19 11:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  1:30 [meta-oe][PATCH 01/17] libwebsockets: rely on cmake.bbclass to put cmake package files in dev package Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 02/17] openobex: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 03/17] rocksdb: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 04/17] capnproto: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 05/17] grpc: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 06/17] json-spirit: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 07/17] librcf: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 08/17] msgpack-c: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 09/17] rapidjson: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 10/17] glm: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 11/17] openjpeg: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 12/17] ceres-solver: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 13/17] gflags: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 14/17] libftdi: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 15/17] libssh: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 16/17] libtinyxml2: " Andre McCurdy
2018-05-18  1:30 ` [meta-oe][PATCH 17/17] poco: " Andre McCurdy
2018-05-18  1:56 ` [meta-oe][PATCH 01/17] libwebsockets: " Khem Raj
2018-05-18 19:07   ` Andre McCurdy
2018-05-18 21:01     ` Khem Raj
2018-05-18 22:28       ` Andre McCurdy
2018-05-19  2:37         ` Trevor Woerner
2018-05-19  4:52           ` Khem Raj
2018-05-19 11:59             ` Peter Kjellerstedt [this message]
2018-05-19 19:35               ` Trevor Woerner
2018-05-20  8:23                 ` André Draszik
2018-05-21 18:10                 ` Andre McCurdy
2018-05-24 17:30                   ` Trevor Woerner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7fbbf37e1ff4631a0aa3b45c07544a9@XBOX02.axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=twoerner@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox