Re: [PATCH 1/2] mozjs: 17.0.0 -> 52.8.1

[Hongxu Jia <hongxu.jia@windriver.com>]

On 2018年07月16日 02:50, Khem Raj wrote:
> On Sun, Jul 15, 2018 at 6:41 AM Hongxu Jia <hongxu.jia@windriver.com> wrote:
>> On 2018年07月14日 01:31, Khem Raj wrote:
>>
>> fails for configure
>> | checking for the Android toolchain directory... not found
>> | Traceback (most recent call last):
>> |   File
>> "/mnt/a/oe/build/tmp/work/cortexa7hf-neon-vfpv4-bec-linux-gnueabi/mozjs/52.8.1-r0/mozjs-52.8.1/js/src/../../configure.py",
>> line 115, in <module>
>> |     sys.exit(main(sys.argv))
>> |   File
>> "/mnt/a/oe/build/tmp/work/cortexa7hf-neon-vfpv4-bec-linux-gnueabi/mozjs/52.8.1-r0/mozjs-52.8.1/js/src/../../configure.py",
>> line 34, in main
>> |     sandbox.run(os.path.join(os.path.dirname(__file__), 'moz.configure'))
>> |   File
>> "/mnt/a/oe/build/tmp/work/cortexa7hf-neon-vfpv4-bec-linux-gnueabi/mozjs/52.8.1-r0/mozjs-52.8.1/python/mozbuild/mozbuild/configure/__init__.py",
>> line 359, in run
>> |     raise InvalidOptionError('Unknown option: %s' % without_value)
>> | mozbuild.configure.options.InvalidOptionError: Unknown option:
>> --disable-static
>>
>> Hi Khem,
>>
>> The `--disable-static' option has already been explicitly removed by me
>>
>> in mozjs 52.8.1, I could not reproduce the failure in my build, would you
>>
>> please paste the reproduce steps, or result of `bitbake -e mozjs' to trace
>>
>> where the option come from
>>
> If you add
>
> require conf/distro/include/no-static-libs.inc
>
> in your local.conf you will see it. Basically you need to set
>
> DISABLE_STATIC = "" in the recipe and that should take care of it.

Thanks for pointing it out, I will set it in V2

> Second look at recipe, I see that it has
>
> ARM_INSTRUCTION_SET = "arm"

Build on qemuarm, without it (using thumb1 specific) still successfully,
I will remove it in V2.

//Hongxu

> the failure you see is thumb1 specific, so lets make this thumb1
> specific as well
> e.g.
>
> ARM_INSTRUCTION_SET_armv5 = "arm"
> ARM_INSTRUCTION_SET_armv4 = "arm"
>
>
>> //Hongxu