Re: Heads up: staging changes are going to land

[Koen Kooi <k.kooi@student.utwente.nl>]

On 03-10-2008 00:25, Richard Purdie wrote:
> Hi,
>
> On Thu, 2008-10-02 at 20:53 +0200, Koen Kooi wrote:
>> The changed described in
>> http://lists.linuxtogo.org/pipermail/openembedded-devel/2008-July/005819.html
>> are about to get committed.
>>
>> The patch can be previewed at
>> http://dominion.thruhere.net/koen/OE/staging-patch.txt
>
> I had a quick glance through that patch and you should probably rethink
> the bits below:
>
> +BUILDSDK_CPPFLAGS = "-isystem${STAGING_INCDIR}"
>   export CPPFLAGS = "${TARGET_CPPFLAGS}"
>   export TARGET_CPPFLAGS = "-isystem${STAGING_DIR_TARGET}${layout_includedir}"
>
>   export BUILD_CFLAGS = "${BUILD_CPPFLAGS} ${BUILD_OPTIMIZATION}"
> +BUILDSDK_CFLAGS = "${BUILDSDK_CPPFLAGS} ${BUILD_OPTIMIZATION}"
>   export CFLAGS = "${TARGET_CFLAGS}"
>   export TARGET_CFLAGS = "${TARGET_CPPFLAGS} ${SELECTED_OPTIMIZATION}"
>
>
> These SDK things are a bit nuts and I suspect should be removed. I added
> them to fix some problem in Poky and I think they may not be needed now
> but I'm not 100% and need to find time to check. OE probably doesn't
> want them, at least yet.

OK

>
> @@ -404,7 +414,7 @@ FULL_OPTIMIZATION = "-fexpensive-optimiz
>   ##################################################################
>
>   FULL_OPTIMIZATION = "-fexpensive-optimizations -fomit-frame-pointer -frename-registers -O2"
> -DEBUG_OPTIMIZATION = "-O -g"
> +DEBUG_OPTIMIZATION = "-O -fno-omit-frame-pointer -g"
>
>
> I think OE changed this for a reason and Poky never merged that change?
> Maybe I don't remember right though?

AIUI you need -fno-omit-frame-pointer on ARM to do profiling, right?

regards,

Koen