From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: Commit policy violations
Date: Thu, 16 Oct 2008 19:34:43 +0200 [thread overview]
Message-ID: <gd7tvk$69e$1@ger.gmane.org> (raw)
In-Reply-To: <871vygv5fo.fsf@neumann.lab.ossystems.com.br>
On 16-10-2008 19:02, Otavio Salvador wrote:
> Koen Kooi<k.kooi@student.utwente.nl> writes:
>
>> Hi,
>>
>> We have had a commit policy for some years now, so it would be nice if
>> people would actually stick to it.
>>
>> So don't do things like this:
>>
>> "[PR] Change PR to FILE_PR and intro PR as FILE_PR + DISTRO_PR"
>>
>> or
>>
>> "[hal] Add latest hal and hal-info"
>>
>> or
>>
>> "add task-fonts-truetype"
>>
>> Those 3 are all *bad*.
>
> Could you explain which would be the good ones?
The git phrasebook has the format:
http://wiki.openembedded.net/index.php/GitPhraseBook
Examples of decent commit messages from today[1]:
"hal_0.5.11.bb : add new version from OM branch"
"xmms: add sed magic to fix builds with gettext > 0.14.0"
"hal 0.5.11: move to nonworking:
* autoreconf fails
* after fixing that it doesn't build"
regards,
Koen
[1] That sentence no verb!
prev parent reply other threads:[~2008-10-16 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 15:08 Commit policy violations Koen Kooi
2008-10-16 17:02 ` Otavio Salvador
2008-10-16 17:34 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gd7tvk$69e$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox