From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: Some review for the stefan/xo-support branch
Date: Wed, 22 Oct 2008 18:07:22 +0200 [thread overview]
Message-ID: <gdnj3q$ei6$2@ger.gmane.org> (raw)
In-Reply-To: <20081022141057.GA8564@dodger.lab.datenfreihafen.org>
On 22-10-2008 16:10, Stefan Schmidt wrote:
> Hello.
>
> I just pushed a branch which adds a machine file for the XO, aka OLPC, laptop
> and a kernel recipe for it.
>
> This allows me to build images for the xo machine in Angstrom.
>
> I don't see how these commits could break anything, but as it is my first
> machine I would like to get some review/acks before pushing it into the main
> tree.
>
> Only three commits:
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=f5fbcf7e4e0228e10fa2c29f802ea0eaabf7a202
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=eff435600359d5f13d846be1480de73e8837133d
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=ed58062633bdba98098044e94ffce9207300e4be
One comment:
+PV = "2.6-olpc+git${SRCREV}"
That should be:
2.6.34+gitr${SRCREV}
regards,
Koen
next prev parent reply other threads:[~2008-10-22 16:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 14:10 Some review for the stefan/xo-support branch Stefan Schmidt
2008-10-22 16:07 ` Koen Kooi [this message]
2008-10-23 17:38 ` Stefan Schmidt
2008-10-23 17:56 ` Koen Kooi
2008-10-23 22:18 ` Stefan Schmidt
2008-10-24 13:08 ` Koen Kooi
2008-10-24 21:26 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gdnj3q$ei6$2@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox