Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: E-Ten Glofiish M800 support
Date: Tue, 18 Nov 2008 17:57:19 +0100	[thread overview]
Message-ID: <gfus5g$aep$1@ger.gmane.org> (raw)
In-Reply-To: <20081118155949.GA2279@datenfreihafen.org>

On 18-11-08 16:59, Stefan Schmidt wrote:
> Hello.
>
> I just pushed a branch with basic machine and kernel support for the M800 from
> E-Ten. Normally Winodws Mobile based device. Linux support is ongoing.
>
> http://git.openembedded.net/?p=openembedded.git;a=commitdiff;h=0ea0875a3e5456f701df08e0974821a4e8852f55
>
> As it is just machine, kernel recipe and sane-srcrev it should not break
> anything. Still I would like to ask for review before pushing it in.
>
> How does folks feel about it?

Only some small comments:

conf/machine/eten-m800.conf:
IMAGE_FSTYPES ?= "tar.gz"

change that to += so people don't shoot themselves in the foot too easily

linux-eten_2.6.24+git.bb:
git://git.openmoko.org/git/kernel.git;protocol=git;branch=stable \

Would it make sense to merge this into the openmoko kernel recipe since 
it's building from the same tree? I'm trying to cut down the number of 
linux-foo recipes whenever possible, but it a seperate recipe is easier, 
go for it.

do_configure_prepend() {
   install -m 0644 ${S}/arch/arm/configs/glofiish_defconfig 
${WORKDIR}/defconfig

Please include the defconfig in OE, it's really tedious to have to add 
patches to SRC_URI when changing the defconfig.

Everything else looks good.

regards,

Koen





  reply	other threads:[~2008-11-18 16:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-18 15:59 E-Ten Glofiish M800 support Stefan Schmidt
2008-11-18 16:57 ` Koen Kooi [this message]
2008-11-18 18:44   ` Stefan Schmidt
2008-11-18 19:28     ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gfus5g$aep$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox