From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: openmoko-merges
Date: Thu, 18 Dec 2008 19:05:51 +0100 [thread overview]
Message-ID: <gie3e0$6th$1@ger.gmane.org> (raw)
In-Reply-To: <1229619255.9166.66.camel@mill.internal.reciva.com>
On 18-12-08 17:54, Phil Blundell wrote:
> On Thu, 2008-12-18 at 16:24 +0100, Koen Kooi wrote:
>> On 18-12-08 16:05, John Lee wrote:
>>> Okay, here is what I will do:
>>>
>>> 1) commit zero controversial part into oe.dev first.
>> You don't know if it's controversial or not without it being reviewed.
>> So no, don't commit stuff.
>
> Is there now a policy of requiring review and pre-approval for all
> checkins to the tree? If so, when was this instigated? I haven't
> noticed any discussion of that and I would not be in favour of any such
> change.
No policy for checkins per se, but for merging commits for large
branches. In this case, a review was requested and the response was to
*not* commit anything.
Asking for a review and then saying "I'll be the judge of things" is a
bit backwards.
The coreteam will make a statement about merging branches soonish.
regards,
Koen
next prev parent reply other threads:[~2008-12-18 18:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 7:19 openmoko-merges John Lee
2008-12-18 9:02 ` openmoko-merges Koen Kooi
2008-12-18 10:11 ` openmoko-merges John Lee
2008-12-18 10:39 ` openmoko-merges Koen Kooi
2008-12-18 14:23 ` openmoko-merges Otavio Salvador
2008-12-18 15:05 ` openmoko-merges John Lee
2008-12-18 15:24 ` openmoko-merges Koen Kooi
2008-12-18 16:35 ` openmoko-merges John Lee
2008-12-18 16:54 ` openmoko-merges Phil Blundell
2008-12-18 18:05 ` Koen Kooi [this message]
2008-12-19 5:38 ` openmoko-merges John Lee
2008-12-19 10:48 ` openmoko-merges Graeme Gregory
2008-12-19 19:46 ` openmoko-merges Ricardo Salveti de Araujo
2008-12-19 20:03 ` openmoko-merges Tom Rini
2008-12-19 23:37 ` openmoko-merges Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gie3e0$6th$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox