From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [PATCH] busybox: update appletlib dependency patch
Date: Tue, 21 Apr 2009 22:29:55 +0200 [thread overview]
Message-ID: <gslac4$lqt$2@ger.gmane.org> (raw)
In-Reply-To: <1238144638-7541-1-git-send-email-khimov@altell.ru>
Acked-by: Koen Kooi <koen@openembedded.org>
On 27-03-09 10:03, Roman I Khimov wrote:
> Previous version still failed from time to time on clean-start builds
> with 4 bitbake threads and '-j16'. Building busybox as sole target worked
> well.
>
> The reason is that previous version introduced a race between applets make
> processes spawned from top-level Makefile and from libbb Makefile.
>
> Fix it with high-level dependency that doesn't create races.
> ---
> .../files/busybox-appletlib-dependency.patch | 24 +++++++++++--------
> 1 files changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/recipes/busybox/files/busybox-appletlib-dependency.patch b/recipes/busybox/files/busybox-appletlib-dependency.patch
> index 85a61e8..3efd4c0 100644
> --- a/recipes/busybox/files/busybox-appletlib-dependency.patch
> +++ b/recipes/busybox/files/busybox-appletlib-dependency.patch
> @@ -1,11 +1,15 @@
> ---- a/libbb/Kbuild 2008-11-09 20:28:09.000000000 +0300
> -+++ b/libbb/Kbuild 2009-02-17 17:41:48.718747865 +0300
> -@@ -147,3 +147,8 @@ lib-$(CONFIG_PGREP) += xregcomp.o
> - lib-$(CONFIG_PKILL) += xregcomp.o
> - lib-$(CONFIG_DEVFSD) += xregcomp.o
> - lib-$(CONFIG_FEATURE_FIND_REGEX) += xregcomp.o
> +Index: busybox-1.13.2/Makefile
> +===================================================================
> +--- busybox-1.13.2.orig/Makefile 2009-03-19 15:44:37.419270265 +0300
> ++++ busybox-1.13.2/Makefile 2009-03-19 15:45:57.737521296 +0300
> +@@ -471,6 +471,10 @@
> + util-linux/ \
> + util-linux/volume_id/ \
> +
> ++# Lib interdeps
> ++# libbb uses headers generated in applets
> ++libbb: applets
> +
> -+libbb/appletlib.o: include/usage_compressed.h include/applet_tables.h
> -+
> -+include/usage_compressed.h include/applet_tables.h:
> -+ $(Q)$(MAKE) $(build)=applets $@
> + endif # KBUILD_EXTMOD
> +
> + ifeq ($(dot-config),1)
next prev parent reply other threads:[~2009-04-21 20:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-27 9:03 [PATCH] busybox: update appletlib dependency patch Roman I Khimov
2009-04-21 20:18 ` Roman I Khimov
2009-04-21 20:29 ` Koen Kooi [this message]
2009-04-22 6:40 ` Holger Schurig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='gslac4$lqt$2@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox