Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [PATCH] image.bbclass: IMAGE_VARS->IMAGE_BOOT, make overridable
Date: Tue, 21 Apr 2009 22:35:05 +0200	[thread overview]
Message-ID: <gslalp$mfs$4@ger.gmane.org> (raw)
In-Reply-To: <1239882421-19769-1-git-send-email-khimov@altell.ru>

I think this should be done in a slightly different way, but that can be 
done after this is in.

Acked-by: Koen Kooi <koen@openembedded.org>


On 16-04-09 13:47, Roman I Khimov wrote:
> IMAGE_VARS usage forces images to have init, dev management, login
> management and other stuff. In cases where you don't need any of those
> (like initramfs images or other special-purpose images) you need to
> override 4 variables in order to get clean image that only installs
> things from IMAGE_INSTALL.
>
> So, this changes IMAGE_VARS to more meaningful IMAGE_BOOT and makes it
> possible to build images without boot components with single
> IMAGE_BOOT="".
> ---
>   classes/image.bbclass |    6 +++---
>   1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/classes/image.bbclass b/classes/image.bbclass
> index fd0df4d..9012de2 100644
> --- a/classes/image.bbclass
> +++ b/classes/image.bbclass
> @@ -17,16 +17,16 @@ IMAGE_INITSCRIPTS ?= "initscripts"
>   #
>   IMAGE_LOGIN_MANAGER ?= "tinylogin"
>
> -IMAGE_VARS = "${IMAGE_INITSCRIPTS} \
> +IMAGE_BOOT ?= "${IMAGE_INITSCRIPTS} \
>   ${IMAGE_DEV_MANAGER} \
>   ${IMAGE_INIT_MANAGER} \
>   ${IMAGE_LOGIN_MANAGER} "
>
> -RDEPENDS += "${IMAGE_INSTALL} ${IMAGE_VARS}"
> +RDEPENDS += "${IMAGE_INSTALL} ${IMAGE_BOOT}"
>
>   # "export IMAGE_BASENAME" not supported at this time
>   IMAGE_BASENAME[export] = "1"
> -export PACKAGE_INSTALL ?= "${IMAGE_INSTALL} ${IMAGE_VARS}"
> +export PACKAGE_INSTALL ?= "${IMAGE_INSTALL} ${IMAGE_BOOT}"
>
>   # We need to recursively follow RDEPENDS and RRECOMMENDS for images
>   do_rootfs[recrdeptask] += "do_deploy do_populate_staging"





      parent reply	other threads:[~2009-04-21 21:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 11:47 [PATCH] image.bbclass: IMAGE_VARS->IMAGE_BOOT, make overridable Roman I Khimov
2009-04-16 19:34 ` Otavio Salvador
2009-04-21 20:19 ` Roman I Khimov
2009-04-21 20:35 ` Koen Kooi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='gslalp$mfs$4@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    --cc=openembedded-devel@openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox