From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@openembedded.org
Subject: Re: [oe-commits] Koen Kooi : util-linux-ng: fix packaging, u-a and replace hardcoded paths
Date: Sat, 20 Jun 2009 12:06:19 +0200 [thread overview]
Message-ID: <h1icar$in$1@ger.gmane.org> (raw)
In-Reply-To: <1245490953.29153.235.camel@lenovo.internal.reciva.com>
On 20-06-09 11:42, Phil Blundell wrote:
>> @@ -129,7 +131,8 @@ do_install () {
>> install -d ${D}${sysconfdir}/default/
>> echo 'MOUNTALL="-t nonfs,nosmbfs,noncpfs"'> ${D}${sysconfdir}/default/mountall
>>
>> - ln -sf ${sbindir}/swapon ${D}${sbindir}/swapoff.${PN}
>> + rm ${D}${sbindir}/swap* -f
>> + ln -sf ${base_sbindir}/swapon.${PN} ${D}${base_sbindir}/swapoff.${PN}
>> ln -sf ${sbindir}/shutdown ${D}${sbindir}/reboot.${PN}
>> ln -sf ${sbindir}/shutdown ${D}${sbindir}/halt.${PN}
>> ln -sf ${sbindir}/shutdown ${D}${sbindir}/fastboot
>
> What's the reason for that "rm"? This looks like it will lose when
> ${base_sbindir} and ${sbindir} are the same directory.
u-l-ng installs a symlink there that breaks finding swapoff at runtime.
base_sbindir and sbindir aren't the same for me, so I can't test what
happens if they are.
regards,
Koen
prev parent reply other threads:[~2009-06-20 10:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-20 9:42 [oe-commits] Koen Kooi : util-linux-ng: fix packaging, u-a and replace hardcoded paths Phil Blundell
2009-06-20 10:06 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='h1icar$in$1@ger.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
--cc=openembedded-devel@openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox