Openembedded Devel Discussions
 help / color / mirror / Atom feed
From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure'.
Date: Wed, 18 Nov 2009 11:32:35 +0100	[thread overview]
Message-ID: <he0ig4$kqa$1@ger.gmane.org> (raw)
In-Reply-To: <1258539954.26517.91.camel@mill.internal.reciva.com>

On 18-11-09 11:25, Phil Blundell wrote:
> On Mon, 2009-11-16 at 23:18 +0100, Przemyslaw Wesolek wrote:
>> Previously, 'menuconfig' task was being run just after 'patch' one. In
>> result, the most common path for unexperienced users:
>>
>> bitbake virtual/kernel -c menuconfig
>> bitbake virtual/kernel -c build
>>
>> didn't work, because the result of 'menuconfig' was later overwritten by
>> 'configure' on the chain of 'build'.
>>
>> With this patch, 'configure' is requirement for 'menuconfig',
>> so any manual changes to the kernel config is done just before
>> actual build and no overwrite occurs.
>
> Thanks for the patch.  That seems like a reasonable change and I think
> it's been proposed before without anybody speaking up in favour of the
> old behaviour.  I checked this in.

Could please use --author in the future when applying patches created by 
other people? We aren't using cvs anymore...

regards,

Koen




      reply	other threads:[~2009-11-18 10:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-10 16:25 addtask menuconfig after do_configure (instead of do_patch)? Leon Woestenberg
2009-11-16 10:38 ` Florian Boor
2009-11-16 22:18 ` [PATCH] Reorganized kernel class to run 'menuconfig' after 'configure' Przemyslaw Wesolek
2009-11-18 10:25   ` Phil Blundell
2009-11-18 10:32     ` Koen Kooi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='he0ig4$kqa$1@ger.gmane.org' \
    --to=k.kooi@student.utwente.nl \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox