From: Koen Kooi <k.kooi@student.utwente.nl>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [PATCH] package.bbclass: when running 'file', be explicit about the path to the magic
Date: Mon, 01 Mar 2010 10:17:05 +0100 [thread overview]
Message-ID: <hmg0mh$ou0$1@dough.gmane.org> (raw)
In-Reply-To: <1266605268-5957-1-git-send-email-clarson@kergoth.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi,
I don't have 'file/' in STAGING_DATADIR_NATIVE so I now have lots of
unstripped stuff (150MB libxul.so). Could you please add an extra check
to see if file/magic exists?
regards,
Koen
On 19-02-10 19:47, Chris Larson wrote:
> From: Tom Rini <tom_rini@mentor.com>
>
> This works around one relocation issue.
>
> Signed-off-by: Tom Rini <tom_rini@mentor.com>
> Signed-off-by: Chris Larson <chris_larson@mentor.com>
> ---
> classes/package.bbclass | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/classes/package.bbclass b/classes/package.bbclass
> index 062f782..72c9053 100644
> --- a/classes/package.bbclass
> +++ b/classes/package.bbclass
> @@ -155,11 +155,12 @@ def runstrip(file, d):
> import commands, stat
>
> pathprefix = "export PATH=%s; " % bb.data.getVar('PATH', d, True)
> + magicfile = "%s/file/magic" % bb.data.getVar('STAGING_DATADIR_NATIVE', d, True)
>
> - ret, result = commands.getstatusoutput("%sfile '%s'" % (pathprefix, file))
> + ret, result = commands.getstatusoutput("%sfile -m %s '%s'" % (pathprefix, magicfile, file))
>
> if ret:
> - bb.error("runstrip: 'file %s' failed (forced strip)" % file)
> + bb.error("runstrip: 'file -m %s %s' failed (forced strip)" % (magicfile, file))
>
> if "not stripped" not in result:
> bb.debug(1, "runstrip: skip %s" % file)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFLi4YRMkyGM64RGpERAoPBAKCdNJV1xR2zZTGU6XSn/jHIDfrNCQCbBFWS
DrZI2u7qsGPg1ABHQh4loHU=
=spj2
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2010-03-01 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-19 18:47 [PATCH] package.bbclass: when running 'file', be explicit about the path to the magic Chris Larson
2010-03-01 9:17 ` Koen Kooi [this message]
2010-03-01 9:35 ` Koen Kooi
2010-03-01 9:45 ` Graeme Gregory
2010-03-01 9:47 ` Koen Kooi
2010-03-01 13:42 ` Chris Larson
2010-03-01 13:51 ` Philip Balister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='hmg0mh$ou0$1@dough.gmane.org' \
--to=k.kooi@student.utwente.nl \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox