Re: patch to fix libstdc++ problem, was Re: Images no longer automatically include libstdc++6

[Koen Kooi <k.kooi@student.utwente.nl>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Apart from bikeshedding on PR bumps, does this patch work for people
besides me and is the solution acceptable for gcc-cross?

On 11-09-10 09:46, Koen Kooi wrote:
> Can people ack or nack the following please:
> 
> 
> diff --git a/recipes/gcc/gcc-package-cross.inc
> b/recipes/gcc/gcc-package-cross.inc
> index 0c4ea2d..59e7dde 100644
> --- a/recipes/gcc/gcc-package-cross.inc
> +++ b/recipes/gcc/gcc-package-cross.inc
> @@ -2,6 +2,8 @@ PACKAGE_STRIP ?= ""
>  OLD_PACKAGE_STRIP := "${PACKAGE_STRIP}"
>  PACKAGE_STRIP = "no"
> 
> +SHLIBSDIR = "${STAGING_DIR_TARGET}/shlibs"
> +
>  PACKAGES = "libgcc libssp libstdc++ libg2c libgfortran"
> 
>  # Called from within gcc-cross, so libdir is set wrong
> 
> 
> On 11-09-10 09:09, Koen Kooi wrote:
>> On 11-09-10 03:29, Dallas Foley wrote:
>>> On 10-09-08 07:33 AM, Philip Balister wrote:
>>>> On 09/08/2010 10:09 AM, pieterg wrote:
>>>>> On Tuesday 07 September 2010 21:03:14 Koen Kooi wrote:
>>>>>> On 07-09-10 18:18, Khem Raj wrote:
>>>>>>> On Tue, Sep 7, 2010 at 5:52 AM, Koen Kooi<k.kooi@student.utwente.nl>
>>>>> wrote:
>>>>>>>> it happens when you build 'gcc' after 'gcc-cross', gcc will doesn't
>>>>>>>> create a libstdc6++ package, but it does create a libstdc-dev
>>>>>>>> package.
>>>>>>>
>>>>>>> I see thats plausible. I think its time to look into separating gcc
>>>>>>> runtime from gcc on the lines of poky.
>>>>>>
>>>>>> I put back libgcc and libstdc++ for the time being:
>>>>>>
>>>>>> http://cgit.openembedded.org/cgit.cgi/openembedded/commit/?id=241b8865f20
>>>>>>
>>>>>> b9e3c3beb334535e6cd8452cbf47d
>>>>>>
>>>>>> I have a feeling the others needs to put back as well (e.g. fortran),
>>>>>> but this fixes the immediate problem.
>>>>>
>>>>> Not for me, after a clean build today packages are still missing
>>>>> libstdc++
>>>>> in their deps (and as a result the images are still missing libstdc++).
>>>>> So there must be more to it.
>>>>
>>>> Does anyone have any idea what commit caused this breakage? It is
>>>> causing a lot
>>>> of problems for people.
>>>>
>>>> Philip
> 
>>> With git bisect I get commit d2a283ad002660e46b2f8d40a8ddfabad457d8a4
>>> that causes libstdc++ to not get included.
> 
>> Yep, that's the one:
> 
>> ./x86_64-linux/shlibs/libssp.ver
>> ./x86_64-linux/shlibs/libstdc++.ver
>> ./x86_64-linux/shlibs/libgfortran.list
>> ./x86_64-linux/shlibs/libssp.list
>> ./x86_64-linux/shlibs/libstdc++.list
>> ./x86_64-linux/shlibs/libgfortran.ver
>> ./x86_64-linux/shlibs/libgcc.list
>> ./x86_64-linux/shlibs/libgcc.ver
> 
>> For gcc we probably need to add the following to gcc.inc:
> 
>> SHLIBSDIR = "${STAGING_DIR}/${BASEPKG_HOST_SYS}/shlibs"
> 
>> That should put the shlibs back where they belong for gcc.
> 
>> regards,
> 
>> Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFMjSFkMkyGM64RGpERAkPvAJwPBO4vhW/iXLTQVdr6AjMoacCJnACeJhyy
N5VkQ1ouu2dCj1tet4p4z6Y=
=9JPc
-----END PGP SIGNATURE-----