Re: [meta-oe][PATCH 1/3] proxy-libintl_20100902.bb: Specify -fPIC in CFLAGS

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 29-04-11 01:31, raj.khem@gmail.com wrote:
> From: Khem Raj <raj.khem@gmail.com>
> 
> Some architectures like mips become upset if you
> try to link non-pic libraries to shared objects
> some generate pic by default so it does not matter
> Specifying -fPIC on commandline should make all happy
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>

This needs a PR bump, since it changes the output.

regards,

Koen

> ---
>  .../proxy-libintl/proxy-libintl_20100902.bb        |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta-oe/recipes-core/proxy-libintl/proxy-libintl_20100902.bb b/meta-oe/recipes-core/proxy-libintl/proxy-libintl_20100902.bb
> index 7c433bd..548e656 100644
> --- a/meta-oe/recipes-core/proxy-libintl/proxy-libintl_20100902.bb
> +++ b/meta-oe/recipes-core/proxy-libintl/proxy-libintl_20100902.bb
> @@ -16,7 +16,7 @@ SRC_URI[sha256sum] = "291ac350cc5eb4a01b0d651ca99fae64cee8a1c06b2005277fab5a4356
>  S = "${WORKDIR}"
>  FILES_${PN}-dev = "${includedir}/libintl.h ${libdir}/libintl.a"
>  
> -CFLAGS_append = " -Wall -I ../../include ${@['-DSTUB_ONLY', ''][bb.data.getVar('USE_NLS', d, 1) != 'no']}"
> +CFLAGS_append = " -fPIC -Wall -I ../../include ${@['-DSTUB_ONLY', ''][bb.data.getVar('USE_NLS', d, 1) != 'no']}"
>  TARGET_CC_ARCH += "${LDFLAGS}"
>  
>  do_compile() {

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFNul90MkyGM64RGpERAryIAKCUVh3wc0iPwSJGc9gXPC8qrhNaDACeLsX3
64BJOcqERBPwYoesfm+2bgY=
=OVMA
-----END PGP SIGNATURE-----