Re: [PATCH] ti-dmai: Fixes for Display and Capture.

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 25-06-11 03:14, Joel A Fernandes wrote:
> These patches fix issues with display and capture in ti-dmai that cause it to break with recent kernels.

Thanks, I applied your patch, but one of them might need an update later on:

> +From 5e59be7d0d5d3d90e9bbc5d1bb5829ad8482fbf0 Mon Sep 17 00:00:00 2001
> +From: Joel A Fernandes <agnel.joel@gmail.com>
> +Date: Fri, 24 Jun 2011 17:04:10 -0500
> +Subject: [PATCH 4/4] DMAI: Use the correct capture device node.
> +
> +Signed-off-by: Joel A Fernandes <agnel.joel@gmail.com>
> +---
> + linux/Capture.c |    2 +-
> + 1 files changed, 1 insertions(+), 1 deletions(-)
> +
> +diff --git a/packages/ti/sdo/dmai/linux/Capture.c b/packages/ti/sdo/dmai/linux/Capture.c
> +index e7a081e..a2614e7 100644
> +--- a/packages/ti/sdo/dmai/linux/Capture.c
> ++++ b/packages/ti/sdo/dmai/linux/Capture.c
> +@@ -120,7 +120,7 @@ const Capture_Attrs Capture_Attrs_OMAP3530_DEFAULT = {
> +     -1,
> +     -1,
> +     -1,
> +-    "/dev/video0",
> ++    "/dev/video2",
> +     FALSE,
> +     VideoStd_AUTO,
> +     -1,

This is still dependant in which order modules get loaded, so like with
the output patch it would be better to iterate over

/sys/class/video4linux/video*/name

And look for the usual suspects (e.g. "OMAP3 ISP CCDC output" on omap3).
I'm not sure how well that works on other platforms, which I why this
patch went in as is :)

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFOBZJyMkyGM64RGpERAgcGAKCGQ/R8hzFpOLaeMQYmvsKEvu2wWACeL70H
ipxR1rKruT7mLTJtpSdKHLU=
=Q0F8
-----END PGP SIGNATURE-----