From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 1/1] debianutils: Add version 2.30 (initial recipe)
Date: Tue, 30 Aug 2011 17:36:47 +0200 [thread overview]
Message-ID: <j3j02f$35m$2@dough.gmane.org> (raw)
In-Reply-To: <989A078976CDAD4CB2DC976EEF70E2A5068A5992@eu2-mail.mgc.mentorg.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 30-08-11 16:21, Ahsan, Noor schreef:
>> -----Original Message----- From: openembedded-devel-bounces@lists.openembedded.org [mailto:openembedded-devel-bounces@lists.openembedded.org] On Behalf
> Of
>> Koen Kooi Sent: Tuesday, August 30, 2011 6:40 PM To: openembedded-devel@lists.openembedded.org Subject: Re: [oe] [meta-oe][PATCH 1/1] debianutils: Add version 2.30 (initial recipe)
>>
> Op 30-08-11 15:24, Noor, Ahsan schreef:
>>>> From: Noor Ahsan <noor_ahsan@mentor.com>
>>>>
>>>> * Imported from oe.dev commit id
> 280a17bc1d8132f97cf6a89b8bc08a32380fa357. * Merged .bb and .inc file
>>>>
>>>> Signed-off-by: Noor Ahsan <noor_ahsan@mentor.com> ---
> .../debianutils/debianutils_2.30.bb | 49 ++++++++++++++++++++
>
>>>> +pkg_prerm_${PN} () { +for app in add-shell installkernel mkboot
> remove-shell run-parts savelog sensible-browser sensible-editor sensible-pager tempfile which ; do + update-alternatives --remove $app $app.${PN} +done +} + +pkg_postinst_${PN} () { +#!/bin/sh +for
>> app
> in add-shell
>>>> installkernel mkboot remove-shell ; do + update-alternatives --
> install ${sbindir}/$app $app $app.${PN} 100 +done +for app in savelog sensible-browser sensible-editor sensible-pager which ; do + update-alternatives --install ${bindir}/$app $app $app.${PN} 100 +done +for app in
>>>> run-parts tempfile ; do + update-alternatives --install
> ${base_bindir}/$app $app $app.${PN} 100 +done +}
>
> The *insts are inconsistent, one has a shebang, the other doesn't and neither are safe to use in a cross environment.
>
>> Koen BTW this is directly coming from oe.dev.
And? It's still wrong
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
iD8DBQFOXQOPMkyGM64RGpERAvYjAJ45fZRDUEa//mXKK1XoU3ByNaQWOQCeNE4q
xQJ2N/zgMWG42dY/6GN/NeM=
=zz1B
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2011-08-30 15:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-30 13:24 [meta-oe][PATCH 0/1] Pull request for debianutils package Noor, Ahsan
2011-08-30 13:24 ` [meta-oe][PATCH 1/1] debianutils: Add version 2.30 (initial recipe) Noor, Ahsan
2011-08-30 13:40 ` Koen Kooi
2011-08-30 14:21 ` Ahsan, Noor
2011-08-30 15:36 ` Koen Kooi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='j3j02f$35m$2@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox