From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lo.gmane.org ([80.91.229.12]) by linuxtogo.org with esmtp (Exim 4.72) (envelope-from ) id 1Qykx2-0002WT-DR for openembedded-devel@lists.openembedded.org; Wed, 31 Aug 2011 15:35:32 +0200 Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QyksJ-0008Iz-LO for openembedded-devel@lists.openembedded.org; Wed, 31 Aug 2011 15:30:39 +0200 Received: from ip545070eb.adsl-surfen.hetnet.nl ([84.80.112.235]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 31 Aug 2011 15:30:39 +0200 Received: from koen by ip545070eb.adsl-surfen.hetnet.nl with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 31 Aug 2011 15:30:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: openembedded-devel@lists.openembedded.org From: Koen Kooi Date: Wed, 31 Aug 2011 15:30:26 +0200 Message-ID: References: <1314745564-3331-1-git-send-email-schnitzeltony@gmx.de> <1314785183.3769.22.camel@mattotaupa> <20110831115548.GB3273@chargestorm.se> Mime-Version: 1.0 X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ip545070eb.adsl-surfen.hetnet.nl User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1 In-Reply-To: X-Enigmail-Version: 1.3.1 Subject: Re: `PR = "r0"`: Add or not to add? X-BeenThere: openembedded-devel@lists.openembedded.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: openembedded-devel@lists.openembedded.org List-Id: Using the OpenEmbedded metadata to build Distributions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2011 13:35:32 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Op 31-08-11 15:02, Otavio Salvador schreef: > On Wed, Aug 31, 2011 at 09:45, Koen Kooi > wrote: >>> Please accept PR = "r0" on new recipes since it makes it more >>> consistent and easy to new users. >> >> Consistent in what way? If you want to be consistent you need to add >> *all* variables to the recipe and set it to their default. > > Not really; consistency has nothing to do with verboseness. PR is > something we will need to change ofthen so makes sense to be in recipes. > > Besides, this is also on the policy The OE classic policy maybe, not on the meta-oe policy[1]. > so or you change the policy or you follow it. Otherwise makes no sense to > have a policy if the person who merge the patches do not follow it. - From http://wiki.openembedded.org/index.php/Category:Policy I read: http://wiki.openembedded.org/index.php/Commit_Patch_Message_Guidelines http://wiki.openembedded.org/index.php/Commit_Policy http://wiki.openembedded.org/index.php/Commit_log_example http://wiki.openembedded.org/index.php/Styleguide http://wiki.openembedded.org/index.php/Versioning_Policy And none of those say PR = r0 is wanted behaviour. OTOH it doesn't say it's unwanted either. regards, Koen [1] There is no such thing yet, what I'm doing now is following the OE-core policies where it makes sense. If someone wants to make a draft policy for the meta-oe layers, please do so. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.5 (Darwin) iD8DBQFOXjdyMkyGM64RGpERAoitAJ98GgMcmfgZqg0va9wQ7zMksseSsgCfS76f f3oPFRWC3aD+EuB6AO+C1QQ= =ahhZ -----END PGP SIGNATURE-----