Re: [PATCH meta-oe 2/9] ietutils: add

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 16-12-11 03:39, b19537@freescale.com schreef:
> From: Zhenhua Luo <b19537@freescale.com>
> 
> The GNU inetutils are a collection of common networking utilities and
> servers including ftp, ftpd, rcp, rexec, rlogin, rlogind, rsh, rshd,
> syslog, syslogd, talk, talkd, telnet, telnetd, tftp, tftpd, and uucpd.
> 
> Signed-off-by: Zhenhua Luo <b19537@freescale.com>

> +++ b/meta-oe/recipes-connectivity/inetutils/inetutils_1.8.bb @@ -0,0
> +1,66 @@ +SECTION = "libs" +DEPENDS = "ncurses fakeroot-native" +LICENSE
> = "GPL"

That's not valid license, please include the version number, e.g. GPLv2 or
GPLv2+

> +DESCRIPTION = "The GNU inetutils are a collection of common \ 
> +networking utilities and servers including ftp, ftpd, rcp, \ +rexec,
> rlogin, rlogind, rsh, rshd, syslog, syslogd, talk, \ +talkd, telnet,
> telnetd, tftp, tftpd, and uucpd."

Please move that to the top

> + +LIC_FILES_CHKSUM =
> "file://COPYING;md5=adefda309052235aa5d1e99ce7557010"

And move that next to LICENSE

> + +SRC_URI = "${GNU_MIRROR}/inetutils/inetutils-${PV}.tar.gz \ +
> file://inetutils-1.8-0001-printf-parse-pull-in-features.h-for-__GLIBC__.patch
> \ +
> file://inetutils-1.8-0002-argp-fix-program_invocation_name-detection.patch
> \ +           file://inetutils-1.8-0003-wchar.patch \ +
> file://inetutils-1.8-1001-ftp-rename-ruserpass-to-avoid-C-library-collision.patch
> \ +
> file://inetutils-1.8-1002-rshd-detect-__rcmd_errstr-support-in-the-C-lib.patch
> \ +
> file://inetutils-1.8-1003-use-daemon-from-the-C-library-when-possible.patch
> \ +           file://inetutils-1.8-1004-detect-fork-support.patch \ +
> file://inetutils-1.8-1005-ftpd-add-daemon-D-nommu-support.patch \ +
> file://fix-disable-ipv6.patch \ +" + +inherit autotools gettext + 
> +noipv6="${@base_contains('DISTRO_FEATURES', 'ipv6', '', '--disable-ipv6
> gl_cv_socket_ipv6=no', d)}" +EXTRA_OECONF =
> "--with-ncurses-include-dir=${STAGING_INCDIR} \ +
> --with-path-procnet-dev=/proc/net/dev \ +		${noipv6} \ +		" + 
> +do_configure_prepend () { +	export HELP2MAN='true' +	cp
> ${STAGING_DATADIR_NATIVE}/gettext/config.rpath
> ${S}/build-aux/config.rpath +	rm -f ${S}/glob/configure* +} + +fakeroot
> do_install () {

explicit fakeroot isn't needed anymore, pseudo always runs.


> +	autotools_do_install +	install -d ${D}${base_sbindir}
> ${D}${base_bindir} +	mv ${D}${bindir}/tftp ${D}${bindir}/tftp.${PN} +	mv
> ${D}${bindir}/telnet ${D}${bindir}/telnet.${PN} +	mv ${D}${bindir}/logger
> ${D}${bindir}/logger.${PN} +	mv ${D}${bindir}/traceroute
> ${D}${bindir}/traceroute.${PN} +	mv ${D}${bindir}/hostname
> ${D}${base_bindir}/hostname.${PN} +	mv ${D}${bindir}/ifconfig
> ${D}${base_sbindir}/ifconfig.${PN} +} + +pkg_postinst_${PN} () { +
> update-alternatives --install ${bindir}/tftp tftp tftp.${PN} 100 +
> update-alternatives --install ${bindir}/telnet telnet telnet.${PN} 100 +
> update-alternatives --install ${bindir}/logger logger logger.${PN} 100 +
> update-alternatives --install ${bindir}/traceroute traceroute
> traceroute.${PN} 100 +	update-alternatives --install
> ${base_bindir}/hostname hostname hostname.${PN} 100 +	update-alternatives
> --install ${base_sbindir}/ifconfig ifconfig ifconfig.${PN} 100 +} + 
> +pkg_prerm_${PN} () { +	update-alternatives --remove tftp tftp.${PN} +
> update-alternatives --remove telnet telnet.${PN} +	update-alternatives
> --remove logger logger.${PN} +	update-alternatives --remove traceroute
> traceroute.${PN} +	update-alternatives --remove ifconfig ifconfig.${PN} 
> +} + +SRC_URI[md5sum] = "ad8fdcdf1797b9ca258264a6b04e48fd" 
> +SRC_URI[sha256sum] =
> "c8500baee04b9ea408c9e65e24ad7f5b41e7d96d42fb1d29abf25b52b68311c7"

Move those next to SRC_URI

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org

iEYEARECAAYFAk7q99kACgkQMkyGM64RGpFtqQCfeLWLjY8SuCe3eSSd8CabPyo0
SNYAn2f32eL5hwGnPC4P9T5CtrYlBCRt
=oxmn
-----END PGP SIGNATURE-----