From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11
Date: Fri, 02 Mar 2012 09:17:17 +0100 [thread overview]
Message-ID: <jipvmb$14d$1@dough.gmane.org> (raw)
In-Reply-To: <1330604440-8121-2-git-send-email-obi@opendreambox.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 01-03-12 13:20, Andreas Oberritter schreef:
> * consolekit fails to build without x11, so disable creation of
> udev-consolekit, if x11 is unavailable.
>
> Signed-off-by: Andreas Oberritter <obi@opendreambox.org> ---
> meta-oe/recipes-core/udev/udev_173.bb | 2 +-
> meta-oe/recipes-core/udev/udev_175.bb | 2 +-
> meta-oe/recipes-core/udev/udev_181.bb | 2 +- 3 files changed, 3
> insertions(+), 3 deletions(-)
>
> diff --git a/meta-oe/recipes-core/udev/udev_173.bb
> b/meta-oe/recipes-core/udev/udev_173.bb index e4e634a..cbbe910 100644 ---
> a/meta-oe/recipes-core/udev/udev_173.bb +++
> b/meta-oe/recipes-core/udev/udev_173.bb @@ -59,7 +59,7 @@
> do_configure_prepend() { INITSCRIPT_NAME = "udev" INITSCRIPT_PARAMS =
> "start 04 S ."
>
> -PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils udev-consolekit"
> +PACKAGES =+ "${PN}-systemd libudev libgudev udev-utils
> ${@base_contains('DISTRO_FEATURES', 'x11', 'udev-consolekit', '', d)}"
What does this actually accomplish? If the package is empty it won't get
generated anyway and if it isn't empty you just introduced a QA error.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (Darwin)
Comment: GPGTools - http://gpgtools.org
iEYEARECAAYFAk9QggsACgkQMkyGM64RGpE5IACgh7qgjWEzWhgUWGBMxCjM86GY
lD4AnRj/2+bgRdsJAt/PJ0Xm0jmK+rVb
=9tpQ
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-03-02 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 12:20 [meta-oe][PATCH 1/2][resend] giflib: don't link against libx11, don't depend on libsm Andreas Oberritter
2012-03-01 12:20 ` [meta-oe][PATCH 2/2][resend] udev: consolekit package requires x11 Andreas Oberritter
2012-03-02 8:17 ` Koen Kooi [this message]
2012-03-02 14:49 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='jipvmb$14d$1@dough.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox