Re: [meta-networking] [PATCH] ptpd: migrate from meta-oe into meta-networking and uprev to ptpd 2.2.0

[Koen Kooi <koen@dominion.thruhere.net>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 26-09-12 05:54, jackie.huang@windriver.com schreef:
> From: Jackie Huang <jackie.huang@windriver.com>
> 

> meta-networking/recipes-daemons/ptpd/ptpd_1.0.0.bb |   20 +++++++ 
> meta-networking/recipes-daemons/ptpd/ptpd_2.2.0.bb |   32 ++++++++++

First: why do we need 2 versions?

> +SUMMARY = "The PTP daemon (PTPd)" +DESCRIPTION = "The PTP daemon (PTPd)
> implements the Precision Time protocol (PTP) as \ +defined by the
> relevant IEEE 1588 standard. PTP Version 1 implements IEEE-1588-2002, \ 
> +and PTP Version 2 implements IEEE-1588-2008. PTP was developed to
> provide very precise \ +time coordination of LAN connected computers." 
> +HOMEPAGE = "http://sourceforge.net/projects/ptpd" +SECTION = "network" 
> +LICENSE = "BSD" + +PR = "r0"

Remove that

> + +LIC_FILES_CHKSUM =
> "file://../COPYRIGHT;md5=3d8ac2c46c116bce2d2ad838b6cf3491"

That goes together with the LICENSE var

> + +SRC_URI =
> "http://downloads.sourceforge.net/project/ptpd/ptpd/${PV}/ptpd-${PV}.tar.gz
> \ +           file://adjust-daemon-name.patch;striplevel=2 \ +
> file://ld-as-needed.patch;striplevel=2 \ +" + +SRC_URI[md5sum] =
> "c63a3a149d30c710773ccb02df5782a3" +SRC_URI[sha256sum] =
> "f2266a22db84318d8b9ce266ea83772c03438c31f4993fa9643fa675a07c26b4" + +S =
> "${WORKDIR}/ptpd-${PV}/src" + +# EXTRA_OEMAKE is typically: -e
> MAKEFLAGS= +# the -e causes problems as CFLAGS is modified in the
> Makefile. +EXTRA_OEMAKE = ""

Modified how? Are the OE CFLAGS and LDFLAGS getting used or not ?

> + +do_install() { +        install -d ${D}${bindir} ${D}${mandir}/man8 +
> install -m 0755 ptpd ${D}${bindir} +        install -m 0644 ptpd2.8
> ${D}${mandir}/man8 +}

is 'make install' broken?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQYq5rMkyGM64RGpERAo2vAJ9GpL7QQJHYGSkxiYC+/ePERYqIrACfUL7Q
lekJzXFfoWZGp43GNgPTY4k=
=h/6e
-----END PGP SIGNATURE-----