From: Koen Kooi <koen@dominion.thruhere.net>
To: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-oe][PATCH v2 2/2] qt4: remove bbappend content
Date: Wed, 10 Apr 2013 18:16:28 +0200 [thread overview]
Message-ID: <kk438m$t0a$1@ger.gmane.org> (raw)
In-Reply-To: <a2eefe761b129b700bbf0a1053a05999ecb69e12.1365609345.git.paul.eggleton@linux.intel.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Op 10-04-13 17:57, Paul Eggleton schreef:
> These changes to Qt's configuration need to be applied in distro layers,
> not in meta-oe.
>
> (We have to preserve the PRINC value to avoid PR going backwards.)
>
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com> ---
> meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend | 5 -----
> meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend | 5 ----- 2 files
> changed, 10 deletions(-)
>
> diff --git a/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend
> b/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend index
> 27cac11..d9f1c29 100644 ---
> a/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend +++
> b/meta-oe/recipes-qt/qt4/qt4-embedded_4.8.4.bbappend @@ -1,6 +1 @@
> -DEPENDS += "mysql5 postgresql sqlite" -QT_SQL_DRIVER_FLAGS =
> "-no-sql-ibase -plugin-sql-mysql -no-sql-odbc -plugin-sql-psql
> -plugin-sql-sqlite2 -plugin-sql-sqlite" -QT_CONFIG_FLAGS +=
> "-I${STAGING_INCDIR}/mysql \ -
> -I${STAGING_INCDIR}/postgresql" - PRINC := "${@int(PRINC) + 1}" diff
> --git a/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend
> b/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend index
> 27cac11..d9f1c29 100644 ---
> a/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend +++
> b/meta-oe/recipes-qt/qt4/qt4-x11-free_4.8.4.bbappend @@ -1,6 +1 @@
> -DEPENDS += "mysql5 postgresql sqlite" -QT_SQL_DRIVER_FLAGS =
> "-no-sql-ibase -plugin-sql-mysql -no-sql-odbc -plugin-sql-psql
> -plugin-sql-sqlite2 -plugin-sql-sqlite" -QT_CONFIG_FLAGS +=
> "-I${STAGING_INCDIR}/mysql \ -
> -I${STAGING_INCDIR}/postgresql" - PRINC := "${@int(PRINC) + 1}"
So with the reason given "I don't want to rebuilt QT when adding meta-oe" to
remove this, this doesn't actually accomplish that. You are adding an extra
rebuild with this.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org
iD8DBQFRZZBcMkyGM64RGpERAh2tAJ44aceRHVjTRLixQw36lBM6hj6FtgCgkjqY
3/srLPdum6RLgzFzCmQRs5I=
=rQLL
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-04-10 16:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-10 15:57 [meta-oe][PATCH v2 0/2] Clean up recipes Paul Eggleton
2013-04-10 15:57 ` [meta-oe][PATCH v2 1/2] packagegroup-qte-toolchain-target: remove bbappend content Paul Eggleton
2013-04-10 15:57 ` [meta-oe][PATCH v2 2/2] qt4: " Paul Eggleton
2013-04-10 16:16 ` Koen Kooi [this message]
2013-04-10 16:26 ` Paul Eggleton
2013-04-11 11:02 ` Anders Darander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='kk438m$t0a$1@ger.gmane.org' \
--to=koen@dominion.thruhere.net \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox