Re: [meta-python][PATCH v2] python-tornado: add missing python2 runtime deps

[Koen Kooi <koen@dominion.thruhere.net>]

Op 01-06-16 om 22:20 schreef S. Lockwood-Childs:
> Sorry about missing character in the previous version, I think this is the
> unmangled version of patch...
> 
> ---
> 
> Tornado 4.3 needs a couple more backport modules to prevent tornado/gen.py
> from bombing on import errors when running on python2 rather than python3.4
> 
>   ImportError: No module named singledispatch
> 
>   ImportError: No module named backports_abc
> 
> Fixed by creating python-singledispatch and python-backports-abc recipes
> respectively and adding them to RDEPENDS.
> 
> Signed-off-by: S. Lockwood-Childs <sjl@vctlabs.com>

It's customary to split a patch like this into 3 patches.

regards,

Koen

> ---
>  .../python/python-backports-abc_0.4.bb                 | 18 ++++++++++++++++++
>  .../python/python-singledispatch_3.4.0.3.bb            | 13 +++++++++++++
>  .../recipes-devtools/python/python-tornado_4.3.bb      |  2 +-
>  3 files changed, 32 insertions(+), 1 deletion(-)
>  create mode 100644 meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
>  create mode 100644 meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb
> 
> diff --git a/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
> new file mode 100644
> index 0000000..6a4d267
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python-backports-abc_0.4.bb
> @@ -0,0 +1,18 @@
> +SUMMARY = "collections.abc from Python 3.4"
> +DESCRIPTION = "A backport of recent additions to the 'collections.abc' module"
> +
> +LICENSE = "PSF"
> +LIC_FILES_CHKSUM = "file://${WORKDIR}/LICENSE;md5=dd98d01d471fac8d8dbdd975229dba03"
> +
> +# pypi package doesn't have valid entry for license
> +SRC_URI += "https://raw.githubusercontent.com/cython/backports_abc/master/LICENSE;name=license"
> +
> +SRC_URI[md5sum] = "0b65a216ce9dc9c1a7e20a729dd7c05b"
> +SRC_URI[sha256sum] = "8b3e4092ba3d541c7a2f9b7d0d9c0275b21c6a01c53a61c731eba6686939d0a5"
> +SRC_URI[license.md5sum] = "dd98d01d471fac8d8dbdd975229dba03"
> +SRC_URI[license.sha256sum] = "0a4f3b38055f50f047a42521568fa6ddb9a5976c2884f6ae138796d0f71150ca"
> +
> +
> +
> +PYPI_PACKAGE = "backports_abc"
> +inherit pypi setuptools
> diff --git a/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb b/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb
> new file mode 100644
> index 0000000..87f46e5
> --- /dev/null
> +++ b/meta-python/recipes-devtools/python/python-singledispatch_3.4.0.3.bb
> @@ -0,0 +1,13 @@
> +SUMMARY = "functools.singledispatch from Python 3.4"
> +DESCRIPTION = "PEP 443 proposed to expose a mechanism in the functools standard library module \
> +in Python 3.4 that provides a simple form of generic programming known as single-dispatch \
> +generic functions.  This library is a backport of this functionality to Python 2.6 - 3.3"
> +
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://README.rst;md5=ee3cd67264adc7eb07981f3644dc17dc"
> +
> +SRC_URI[md5sum] = "af2fc6a3d6cc5a02d0bf54d909785fcb"
> +SRC_URI[sha256sum] = "5b06af87df13818d14f08a028e42f566640aef80805c3b50c5056b086e3c2b9c"
> +
> +PYPI_PACKAGE = "singledispatch"
> +inherit pypi setuptools
> diff --git a/meta-python/recipes-devtools/python/python-tornado_4.3.bb b/meta-python/recipes-devtools/python/python-tornado_4.3.bb
> index 55a48b8..d30f88f 100644
> --- a/meta-python/recipes-devtools/python/python-tornado_4.3.bb
> +++ b/meta-python/recipes-devtools/python/python-tornado_4.3.bb
> @@ -1,3 +1,3 @@
>  inherit pypi setuptools
>  require python-tornado.inc
> -RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl"
> +RDEPENDS_${PN} += "${PYTHON_PN}-backports-ssl ${PYTHON_PN}-backports-abc ${PYTHON_PN}-singledispatch"
>