linux-openrisc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 14/30] memblock: add align parameter to memblock_alloc_node()
Date: Wed, 26 Sep 2018 16:43:35 +0300	[thread overview]
Message-ID: <20180926134335.GF4628@rapoport-lnx> (raw)
In-Reply-To: <20180926093648.GP6278@dhcp22.suse.cz>

On Wed, Sep 26, 2018 at 11:36:48AM +0200, Michal Hocko wrote:
> On Wed 26-09-18 11:31:27, Michal Hocko wrote:
> > On Fri 14-09-18 15:10:29, Mike Rapoport wrote:
> > > With the align parameter memblock_alloc_node() can be used as drop in
> > > replacement for alloc_bootmem_pages_node() and __alloc_bootmem_node(),
> > > which is done in the following patches.
> > 
> > /me confused. Why do we need this patch at all? Maybe it should be
> > folded into the later patch you are refereing here?
> 
> OK, I can see 1536927045-23536-17-git-send-email-rppt at linux.vnet.ibm.com
> now. If you are going to repost for whatever reason please merge those
> two. Also I would get rid of the implicit "0 implies SMP_CACHE_BYTES"
> behavior. It is subtle and you have to dig deep to find that out. Why
> not make it explicit?

Agree. I'd just prefer to make it a separate patch rather then resend the
whole series. 

> -- 
> Michal Hocko
> SUSE Labs
> 

-- 
Sincerely yours,
Mike.


  reply	other threads:[~2018-09-26 13:43 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-14 12:10 [OpenRISC] [PATCH 00/30] mm: remove bootmem allocator Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 01/30] mips: switch to NO_BOOTMEM Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 02/30] mm: remove CONFIG_NO_BOOTMEM Mike Rapoport
2018-09-26  9:22   ` Michal Hocko
2018-09-26 11:48     ` Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 03/30] mm: remove CONFIG_HAVE_MEMBLOCK Mike Rapoport
2018-09-26  9:24   ` Michal Hocko
2018-09-26 11:54     ` Mike Rapoport
2018-09-26 16:58   ` Alexander Duyck
2018-09-26 18:31     ` Mike Rapoport
2018-09-27  0:34       ` Alexander Duyck
2018-09-27  4:50         ` Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 04/30] mm: remove bootmem allocator implementation Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 05/30] mm: nobootmem: remove dead code Mike Rapoport
2018-09-26  9:25   ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 06/30] memblock: rename memblock_alloc{_nid, _try_nid} to memblock_phys_alloc* Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 07/30] memblock: remove _virt from APIs returning virtual address Mike Rapoport
2018-09-26  9:27   ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 08/30] memblock: replace alloc_bootmem_align with memblock_alloc Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 09/30] memblock: replace alloc_bootmem_low with memblock_alloc_low Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 10/30] memblock: replace __alloc_bootmem_node_nopanic with memblock_alloc_try_nid_nopanic Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 11/30] memblock: replace alloc_bootmem_pages_nopanic with memblock_alloc_nopanic Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 12/30] memblock: replace alloc_bootmem_low with memblock_alloc_low Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 13/30] memblock: replace __alloc_bootmem_nopanic with memblock_alloc_from_nopanic Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 14/30] memblock: add align parameter to memblock_alloc_node() Mike Rapoport
2018-09-26  9:31   ` Michal Hocko
2018-09-26  9:36     ` Michal Hocko
2018-09-26 13:43       ` Mike Rapoport [this message]
2018-09-26 14:23         ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 15/30] memblock: replace alloc_bootmem_pages_node with memblock_alloc_node Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 16/30] memblock: replace __alloc_bootmem_node with appropriate memblock_ API Mike Rapoport
2018-09-26  9:37   ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 17/30] memblock: replace alloc_bootmem_node with memblock_alloc_node Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 18/30] memblock: replace alloc_bootmem_low_pages with memblock_alloc_low Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 19/30] memblock: replace alloc_bootmem_pages with memblock_alloc Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 20/30] memblock: replace __alloc_bootmem with memblock_alloc_from Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 21/30] memblock: replace alloc_bootmem with memblock_alloc Mike Rapoport
2018-09-26  9:38   ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 22/30] mm: nobootmem: remove bootmem allocation APIs Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 23/30] memblock: replace free_bootmem{_node} with memblock_free Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 24/30] memblock: replace free_bootmem_late with memblock_free_late Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 25/30] memblock: rename free_all_bootmem to memblock_free_all Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 26/30] memblock: rename __free_pages_bootmem to memblock_free_pages Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 27/30] mm: remove nobootmem Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 28/30] memblock: replace BOOTMEM_ALLOC_* with MEMBLOCK variants Mike Rapoport
2018-09-14 12:10 ` [OpenRISC] [PATCH 29/30] mm: remove include/linux/bootmem.h Mike Rapoport
2018-09-26  9:38   ` Michal Hocko
2018-09-14 12:10 ` [OpenRISC] [PATCH 30/30] docs/boot-time-mm: remove bootmem documentation Mike Rapoport
2018-09-26  9:41 ` [OpenRISC] [PATCH 00/30] mm: remove bootmem allocator Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180926134335.GF4628@rapoport-lnx \
    --to=rppt@linux.vnet.ibm.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).