[OpenRISC] [PATCH v3 1/3] or1k: libgcc: initial support for openrisc

Segher Boessenkool
2018-10-27T23:25:04Z

Hi!

On Sat, Oct 27, 2018 at 01:37:00PM +0900, Stafford Horne wrote:
> + /* Given R = X * Y ... */
> +1: l.sfeq r4, r0 /* while (y != 0) */
> + l.bf 2f
> + l.andi r5, r4, 1 /* if (y & 1) ... */

Do the extra leading spaces mean something?

> + l.sfeqi r4, 0 /* division by zero; return 0. */

In some places (like here) you ident with 8 spaces instead of a tab.

> +/* For signed division we do:
> + *
> + * -x / y = x / -y = -(x / y)
> + * -x % y = -(x % y)
> + * x % -y = x % b
> + *
> + * which has the property that (x/y)*y + (x%y) = x.
> + */

You mean "y" instead of "b" I think.

Segher