[OpenRISC] [PATCH v3 3/3] or1k: gcc: initial support for openrisc

Segher Boessenkool
2018-10-30T15:49:53Z

On Tue, Oct 30, 2018 at 09:49:18PM +0900, Stafford Horne wrote:
> Hello,
>
> On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote:
> > Yes, like that. It also easily can handle the other combos (those with
> > STACK_POINTER), and it is easier if you have to switch FRAME_GROWS_DOWNWARD
> > ("false" is better on some args, but "true" is required for ssp).
> >
> > Your code is fine as-is of course.
>
> Just to be clear, when you say 'as-is' did you mean the original v3 patch? Or
> are you referring to followup patch I posted with the some_offset (from) -
> some_offset (to) logic.

Either. Both. I meant the orig big patch, v3 if that's what it was.

I am not a global reviewer; this is all just my opinion :-)

Segher