From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Rapoport Date: Wed, 13 May 2020 08:23:20 +0300 Subject: [OpenRISC] [PATCH 08/12] mm: pgtable: add shortcuts for accessing kernel PMD and PTE In-Reply-To: <20200512192441.GZ16070@bombadil.infradead.org> References: <20200512184422.12418-1-rppt@kernel.org> <20200512184422.12418-9-rppt@kernel.org> <20200512192441.GZ16070@bombadil.infradead.org> Message-ID: <20200513052320.GO14260@kernel.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Tue, May 12, 2020 at 12:24:41PM -0700, Matthew Wilcox wrote: > On Tue, May 12, 2020 at 09:44:18PM +0300, Mike Rapoport wrote: > > +++ b/include/linux/pgtable.h > > @@ -28,6 +28,24 @@ > > #define USER_PGTABLES_CEILING 0UL > > #endif > > > > +/* FIXME: */ > > Fix you what? Add documentation? Ouch, indeed :) > > +static inline pmd_t *pmd_off(struct mm_struct *mm, unsigned long va) > > +{ > > + return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va); > > +} -- Sincerely yours, Mike.