From: Kees Cook <keescook@chromium.org>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 02/20] exit: Remove calls of do_exit after noreturn versions of die
Date: Thu, 21 Oct 2021 09:02:04 -0700 [thread overview]
Message-ID: <202110210858.41719190D2@keescook> (raw)
In-Reply-To: <20211020174406.17889-2-ebiederm@xmission.com>
On Wed, Oct 20, 2021 at 12:43:48PM -0500, Eric W. Biederman wrote:
> On nds32, openrisc, s390, sh, and xtensa the function die never
> returns. Mark die __noreturn so that no one expects die to return.
> Remove the do_exit calls after die as they will never be reached.
Maybe note that the "bust_spinlocks" calls are also redundant, since
they're in die(). I note that is a "mismatch" between the do_kill()
in die() (SIGSEGV) and after die() (SIGKILL). This patch makes no
behavioral change (the first caller would "win"), but I thought I'd note
it in case some architecture would prefer a different signal.
Reviewed-by: Kees Cook <keescook@chromium.org>
-Kees
--
Kees Cook
next prev parent reply other threads:[~2021-10-21 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 17:32 [OpenRISC] [PATCH 00/20] exit cleanups Eric W. Biederman
2021-10-20 17:43 ` [OpenRISC] [PATCH 02/20] exit: Remove calls of do_exit after noreturn versions of die Eric W. Biederman
2021-10-21 16:02 ` Kees Cook [this message]
2021-10-21 16:25 ` Eric W. Biederman
2021-10-20 21:51 ` [OpenRISC] [PATCH 21/20] signal: Replace force_sigsegv(SIGSEGV) with force_fatal_sig(SIGSEGV) Eric W. Biederman
2021-10-21 8:09 ` Geert Uytterhoeven
2021-10-21 13:33 ` Eric W. Biederman
2021-10-21 8:32 ` Philippe =?unknown-8bit?q?Mathieu-Daud=C3=A9?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110210858.41719190D2@keescook \
--to=keescook@chromium.org \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox