From: Stafford Horne <shorne@gmail.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Cc: Linux OpenRISC <linux-openrisc@vger.kernel.org>,
Stafford Horne <shorne@gmail.com>
Subject: [PATCH] or1k: Fix 64-bit shifts on OpenRISC
Date: Thu, 4 Jun 2026 19:06:34 +0100 [thread overview]
Message-ID: <20260604180634.1920890-1-shorne@gmail.com> (raw)
On OpenRISC, 64-bit shift tests shiftdi-2.c and vshift-1.c were failing
and it looks to always have been broken.
After investigation it was found that OpenRISC fails to define
SHIFT_COUNT_TRUNCATED which is needed as both register and immediate
shift amounts are unsigned and only use the low-order 5 bits. Also,
the immediate used for 32-bit shifts is an unsigned 5-bit value not a
6-bit value; update the predicate.
After these changes the tests pass.
$ make check-gcc RUNTESTFLAGS='dg.exp=vshift-1.c execute.exp=shiftdi-2.c'
# of expected passes 14
gcc/ChangeLog:
* config/or1k/or1k.h (SHIFT_COUNT_TRUNCATED): Define.
* config/or1k/or1k.md (rotrsi3): Rename reg_or_u6_operand to
reg_or_u5_operand.
(<shift_op>si3): Ditto.
* config/or1k/predicates.md (reg_or_u6_operand): Remove.
(reg_or_u5_operand): New predicate.
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
gcc/config/or1k/or1k.h | 3 +++
gcc/config/or1k/or1k.md | 4 ++--
gcc/config/or1k/predicates.md | 8 ++++----
3 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/gcc/config/or1k/or1k.h b/gcc/config/or1k/or1k.h
index ee3a7814f09..af043f8c2d9 100644
--- a/gcc/config/or1k/or1k.h
+++ b/gcc/config/or1k/or1k.h
@@ -394,6 +394,9 @@ do { \
/* All the work is done in PROFILE_HOOK, but this is still required. */
#define FUNCTION_PROFILER(STREAM, LABELNO) do { } while (0)
+/* Shift instructions ignore all but the low-order few bits. */
+#define SHIFT_COUNT_TRUNCATED 1
+
/* Dwarf 2 Support */
#define DWARF2_DEBUGGING_INFO 1
#define INCOMING_RETURN_ADDR_RTX gen_rtx_REG (Pmode, LR_REGNUM)
diff --git a/gcc/config/or1k/or1k.md b/gcc/config/or1k/or1k.md
index d3fbb209be7..6de0dc26511 100644
--- a/gcc/config/or1k/or1k.md
+++ b/gcc/config/or1k/or1k.md
@@ -217,7 +217,7 @@
(define_insn "<shift_op>si3"
[(set (match_operand:SI 0 "register_operand" "=r,r")
(SHIFT:SI (match_operand:SI 1 "register_operand" "r,r")
- (match_operand:SI 2 "reg_or_u6_operand" "r,n")))]
+ (match_operand:SI 2 "reg_or_u5_operand" "r,n")))]
""
"@
l.<shift_asm>\t%0, %1, %2
@@ -227,7 +227,7 @@
(define_insn "rotrsi3"
[(set (match_operand:SI 0 "register_operand" "=r,r")
(rotatert:SI (match_operand:SI 1 "register_operand" "r,r")
- (match_operand:SI 2 "ror_reg_or_u6_operand" "r,n")))]
+ (match_operand:SI 2 "ror_reg_or_u5_operand" "r,n")))]
"TARGET_ROR || TARGET_RORI"
"@
l.ror\t%0, %1, %2
diff --git a/gcc/config/or1k/predicates.md b/gcc/config/or1k/predicates.md
index cde49a3754c..1f78e57366d 100644
--- a/gcc/config/or1k/predicates.md
+++ b/gcc/config/or1k/predicates.md
@@ -38,9 +38,9 @@
(ior (match_operand 0 "register_operand")
(match_operand 0 "const0_operand")))
-(define_predicate "reg_or_u6_operand"
+(define_predicate "reg_or_u5_operand"
(if_then_else (match_code "const_int")
- (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 0x3f")
+ (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 0x1f")
(match_operand 0 "register_operand")))
(define_predicate "reg_or_u16_operand"
@@ -53,9 +53,9 @@
(match_test "INTVAL (op) >= -32768 && INTVAL (op) <= 32767")
(match_operand 0 "register_operand")))
-(define_predicate "ror_reg_or_u6_operand"
+(define_predicate "ror_reg_or_u5_operand"
(if_then_else (match_code "const_int")
- (and (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 0x3f")
+ (and (match_test "INTVAL (op) >= 0 && INTVAL (op) <= 0x1f")
(match_test "TARGET_RORI"))
(and (match_operand 0 "register_operand")
(match_test "TARGET_ROR"))))
--
2.53.0
reply other threads:[~2026-06-04 18:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260604180634.1920890-1-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linux-openrisc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox