From: Stafford Horne <shorne@gmail.com>
To: QEMU Development <qemu-devel@nongnu.org>
Cc: "Linux OpenRISC" <linux-openrisc@vger.kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Ali Ahmet Memiş" <ali@iusegentoo.com>,
"Stafford Horne" <shorne@gmail.com>
Subject: [PULL 1/1] target/or1k: Implement l.extws and l.extwz
Date: Sun, 13 Sep 2026 08:03:03 +0100 [thread overview]
Message-ID: <20260913070303.1010504-2-shorne@gmail.com> (raw)
In-Reply-To: <20260913070303.1010504-1-shorne@gmail.com>
From: Ali Ahmet Memiş <ali@iusegentoo.com>
l.extws and l.extwz belong to the ORBIS32 instruction set, but the
decoder has no entries for them, so they raise an illegal instruction
exception on every CPU model.
On a 32-bit implementation both are register moves: there is nothing
above bit 31 to extend into. Implement them as such.
Found while writing an OpenRISC port of Valgrind.
Signed-off-by: Ali Ahmet Memiş <ali@iusegentoo.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Stafford Horne <shorne@gmail.com>
---
target/or1k/disas.c | 2 ++
target/or1k/insns.decode | 2 ++
target/or1k/translate.c | 14 ++++++++++++++
3 files changed, 18 insertions(+)
diff --git a/target/or1k/disas.c b/target/or1k/disas.c
index dc025bd64d..0a46d68d30 100644
--- a/target/or1k/disas.c
+++ b/target/or1k/disas.c
@@ -71,6 +71,8 @@ INSN(exths, "r%d, r%d", a->d, a->a)
INSN(extbs, "r%d, r%d", a->d, a->a)
INSN(exthz, "r%d, r%d", a->d, a->a)
INSN(extbz, "r%d, r%d", a->d, a->a)
+INSN(extws, "r%d, r%d", a->d, a->a)
+INSN(extwz, "r%d, r%d", a->d, a->a)
INSN(cmov, "r%d, r%d, r%d", a->d, a->a, a->b)
INSN(ff1, "r%d, r%d", a->d, a->a)
INSN(fl1, "r%d, r%d", a->d, a->a)
diff --git a/target/or1k/insns.decode b/target/or1k/insns.decode
index 0d6f7c29f8..cbf8af7f8b 100644
--- a/target/or1k/insns.decode
+++ b/target/or1k/insns.decode
@@ -112,6 +112,8 @@ l_exths 111000 d:5 a:5 ----- - 0000 -- 1100
l_extbs 111000 d:5 a:5 ----- - 0001 -- 1100
l_exthz 111000 d:5 a:5 ----- - 0010 -- 1100
l_extbz 111000 d:5 a:5 ----- - 0011 -- 1100
+l_extws 111000 d:5 a:5 ----- - 0000 -- 1101
+l_extwz 111000 d:5 a:5 ----- - 0001 -- 1101
l_add 111000 d:5 a:5 b:5 - 00 ---- 0000
l_addc 111000 d:5 a:5 b:5 - 00 ---- 0001
diff --git a/target/or1k/translate.c b/target/or1k/translate.c
index eb4485312f..e00ef45b9b 100644
--- a/target/or1k/translate.c
+++ b/target/or1k/translate.c
@@ -502,6 +502,20 @@ static bool trans_l_extbz(DisasContext *dc, arg_da *a)
return true;
}
+static bool trans_l_extws(DisasContext *dc, arg_da *a)
+{
+ check_r0_write(dc, a->d);
+ tcg_gen_mov_i32(cpu_R(dc, a->d), cpu_R(dc, a->a));
+ return true;
+}
+
+static bool trans_l_extwz(DisasContext *dc, arg_da *a)
+{
+ check_r0_write(dc, a->d);
+ tcg_gen_mov_i32(cpu_R(dc, a->d), cpu_R(dc, a->a));
+ return true;
+}
+
static bool trans_l_cmov(DisasContext *dc, arg_dab *a)
{
check_r0_write(dc, a->d);
--
2.53.0
prev parent reply other threads:[~2026-09-13 7:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-13 7:03 [PULL 0/1] OpenRISC Updates 2026-09-13 Stafford Horne
2026-09-13 7:03 ` Stafford Horne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260913070303.1010504-2-shorne@gmail.com \
--to=shorne@gmail.com \
--cc=ali@iusegentoo.com \
--cc=linux-openrisc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox