From: Yao Qi <qiyaoltc@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support
Date: Mon, 12 Jun 2017 10:45:15 +0100 [thread overview]
Message-ID: <86lgoxa6ac.fsf@gmail.com> (raw)
In-Reply-To: <20170610081138.GD8558@lianli.shorne-pla.net> (Stafford Horne's message of "Sat, 10 Jun 2017 17:11:38 +0900")
Stafford Horne <shorne@gmail.com> writes:
> I tried to look into this, but it looks liek we do need
> set_gdbarch_print_insn (). If not starting gdb hits this error in
> gdbarch.c verify_gdbarch().
>
> ...
> if (gdbarch->print_insn == 0)
> log.puts ("\n\tprint_insn");
These lines were removed by my commit
39503f82427e22ed8e04d986ccdc8562091ec62e (Delegate opcodes to select
disassembler in GDB) on May 24th.
- if (gdbarch->print_insn == 0)
- log.puts ("\n\tprint_insn");
+ /* Skip verify of print_insn, invalid_p == 0 */
> ...
>
> if (!log.empty ())
> internal_error (__FILE__, __LINE__,
> _("verify_gdbarch: the following are invalid ...%s"),
> log.c_str ());
> ...
>
> Is the automatic selecting of `print_insn` something new? My patch is
> based on yesterdays master branch of http://sourceware.org/git/binutils-gdb.git.
Looks your gdbarch.c is out of date.
--
Yao (齐尧)
next prev parent reply other threads:[~2017-06-12 9:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-29 14:48 [OpenRISC] [PATCH v7 0/4] OpenRISC gdb port Stafford Horne
2017-05-29 14:48 ` [OpenRISC] [PATCH v7 1/4] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-06-09 10:10 ` Yao Qi
2017-06-09 13:08 ` Stafford Horne
2017-06-10 8:11 ` Stafford Horne
2017-06-12 9:45 ` Yao Qi [this message]
2017-06-13 10:14 ` Stafford Horne
2017-05-29 14:48 ` [OpenRISC] [PATCH v7 2/4] gdb: testsuite: Add or1k l.nop instruction Stafford Horne
2017-06-09 10:11 ` Yao Qi
2017-05-29 14:48 ` [OpenRISC] [PATCH v7 3/4] gdb: testsuite: Add or1k tdesc-regs.exp test support Stafford Horne
2017-06-09 10:11 ` Yao Qi
2017-05-29 14:48 ` [OpenRISC] [PATCH v7 4/4] Add gdb for or1k build Stafford Horne
2017-12-08 21:28 ` Stafford Horne
2017-12-12 14:04 ` Stafford Horne
2017-12-12 14:05 ` Richard Biener
2017-12-12 15:12 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86lgoxa6ac.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).