From: Yao Qi <qiyaoltc@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
Date: Tue, 09 May 2017 15:21:43 +0100 [thread overview]
Message-ID: <86o9v2t8js.fsf@gmail.com> (raw)
In-Reply-To: <dbd35ae7e8f9ca8db89dd14b81119d3eb50afb98.1493038197.git.shorne@gmail.com> (Stafford Horne's message of "Mon, 24 Apr 2017 21:52:50 +0900")
Stafford Horne <shorne@gmail.com> writes:
>
> if (reggroup == general_reggroup)
> return general_p;
> +
> + if (strcmp (reg->group, reggroup_name (reggroup)) == 0)
> + return 1;
> +
> }
I read the patch again, and find that we can replace the whole block in
"if (reg != NULL && reg->group != NULL)" with the code this patch adds,
like this,
if (reg != NULL && reg->group != NULL
&& (strcmp (reg->group, reggroup_name (reggroup)) == 0))
return 1;
--
Yao (齐尧)
next prev parent reply other threads:[~2017-05-09 14:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 12:52 [OpenRISC] [PATCH v6 0/5] OpenRISC gdb port Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-05-02 14:40 ` Yao Qi
2017-05-02 15:41 ` Stafford Horne
2017-05-09 13:54 ` Yao Qi
2017-05-20 6:42 ` Stafford Horne
2017-05-09 14:21 ` Yao Qi [this message]
2017-05-16 11:20 ` Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 2/5] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-04-26 5:59 ` Eli Zaretskii
2017-04-26 12:04 ` Stafford Horne
2017-05-02 14:32 ` Yao Qi
2017-05-02 15:53 ` Stafford Horne
2017-05-09 14:15 ` Yao Qi
2017-05-16 11:18 ` Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 3/5] gdb: testsuite: Add or1k l.nop instruction Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 4/5] gdb: testsuite: Add or1k tdesc-regs.exp test support Stafford Horne
2017-05-02 14:36 ` Yao Qi
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 5/5] Add gdb for or1k build Stafford Horne
2017-05-02 14:38 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86o9v2t8js.fsf@gmail.com \
--to=qiyaoltc@gmail.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).