linux-openrisc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yao Qi <qiyaoltc@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p
Date: Tue, 09 May 2017 14:54:01 +0100	[thread overview]
Message-ID: <86wp9qt9ty.fsf@gmail.com> (raw)
In-Reply-To: <20170502154115.GH2724@lianli.shorne-pla.net> (Stafford Horne's message of "Wed, 3 May 2017 00:41:15 +0900")

Stafford Horne <shorne@gmail.com> writes:

> This change is to also allow returning true in the case that the register
> group was registered with gdb with reggroup_add().  This seems like
> something that will be generally required so it was added to the
> target-descriptions definition.  If you think not I can make it for
> openrisc only, but I think it makes more sense in tdesc.

Thanks for the explanation.

>
> This allows the command like, the below to return the registers for the
> named reggroup.
>
>   info reg system

Some bits are missing,

 - A test case, in which we can define some reggroups "foo" and test
   expected "foo" is shown in the output of "maintenance print
   reggroups".  You can add reggroups in gdb.xml/extra-regs.xml.

 - A test case with live inferior, get a list of support reggroups from
   the output of "maint print reggroups", pass each reggroup to "info
   reg $group", and test there is no error.

 - Document "info registers".
   https://sourceware.org/gdb/current/onlinedocs/gdb/Registers.html
   doesn't document the usage "info reg GROUP".  We need to add it.

 - Add a news entry, because your patch adds a user visible change.

-- 
Yao (齐尧)

  reply	other threads:[~2017-05-09 13:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24 12:52 [OpenRISC] [PATCH v6 0/5] OpenRISC gdb port Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 1/5] tdesc: handle arbitrary strings in tdesc_register_in_reggroup_p Stafford Horne
2017-05-02 14:40   ` Yao Qi
2017-05-02 15:41     ` Stafford Horne
2017-05-09 13:54       ` Yao Qi [this message]
2017-05-20  6:42         ` Stafford Horne
2017-05-09 14:21   ` Yao Qi
2017-05-16 11:20     ` Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 2/5] gdb: Add OpenRISC or1k and or1knd target support Stafford Horne
2017-04-26  5:59   ` Eli Zaretskii
2017-04-26 12:04     ` Stafford Horne
2017-05-02 14:32   ` Yao Qi
2017-05-02 15:53     ` Stafford Horne
2017-05-09 14:15       ` Yao Qi
2017-05-16 11:18         ` Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 3/5] gdb: testsuite: Add or1k l.nop instruction Stafford Horne
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 4/5] gdb: testsuite: Add or1k tdesc-regs.exp test support Stafford Horne
2017-05-02 14:36   ` Yao Qi
2017-04-24 12:52 ` [OpenRISC] [PATCH v6 5/5] Add gdb for or1k build Stafford Horne
2017-05-02 14:38   ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86wp9qt9ty.fsf@gmail.com \
    --to=qiyaoltc@gmail.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).