From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stafford Horne Date: Thu, 7 Oct 2021 05:44:00 +0900 Subject: [OpenRISC] [PATCH 06/12] openrisc: Use of_get_cpu_hwid() In-Reply-To: <20211006164332.1981454-7-robh@kernel.org> References: <20211006164332.1981454-1-robh@kernel.org> <20211006164332.1981454-7-robh@kernel.org> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: openrisc@lists.librecores.org On Wed, Oct 06, 2021 at 11:43:26AM -0500, Rob Herring wrote: > Replace open coded parsing of CPU nodes' 'reg' property with > of_get_cpu_hwid(). > > Cc: Jonas Bonn > Cc: Stefan Kristiansson > Cc: Stafford Horne > Cc: openrisc at lists.librecores.org > Signed-off-by: Rob Herring > --- > arch/openrisc/kernel/smp.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/arch/openrisc/kernel/smp.c b/arch/openrisc/kernel/smp.c > index 415e209732a3..7d5a4f303a5a 100644 > --- a/arch/openrisc/kernel/smp.c > +++ b/arch/openrisc/kernel/smp.c > @@ -65,11 +65,7 @@ void __init smp_init_cpus(void) > u32 cpu_id; > > for_each_of_cpu_node(cpu) { > - if (of_property_read_u32(cpu, "reg", &cpu_id)) { > - pr_warn("%s missing reg property", cpu->full_name); > - continue; > - } > - > + cpu_id = of_get_cpu_hwid(cpu); You have defined of_get_cpu_hwid to return u64, will this create compiler warnings when since we are storing a u64 into a u32? It seems only if we make with W=3. I thought we usually warned on this. Oh well, for the openrisc bits. Acked-by: Stafford Horne > if (cpu_id < NR_CPUS) > set_cpu_possible(cpu_id, true); > } > -- > 2.30.2 >