public inbox for openrisc@lists.librecores.org
 help / color / mirror / Atom feed
From: Calvin Zhang <calvinzhang.cool@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH 0/2] of: remove reserved regions count restriction
Date: Sun, 21 Nov 2021 17:01:20 +0800	[thread overview]
Message-ID: <YZoK4IiBOTPduEyN@debian> (raw)
In-Reply-To: <YZnqo3oA7srQik4N@kernel.org>

On Sun, Nov 21, 2021 at 08:43:47AM +0200, Mike Rapoport wrote:
>On Fri, Nov 19, 2021 at 03:58:17PM +0800, Calvin Zhang wrote:
>> The count of reserved regions in /reserved-memory was limited because
>> the struct reserved_mem array was defined statically. This series sorts
>> out reserved memory code and allocates that array from early allocator.
>> 
>> Note: reserved region with fixed location must be reserved before any
>> memory allocation. While struct reserved_mem array should be allocated
>> after allocator is activated. We make early_init_fdt_scan_reserved_mem()
>> do reservation only and add another call to initialize reserved memory.
>> So arch code have to change for it.
>
>I think much simpler would be to use the same constant for sizing
>memblock.reserved and reserved_mem arrays.
>
>If there is too much reserved regions in the device tree, reserving them in
>memblock will fail anyway because memblock also starts with static array
>for memblock.reserved, so doing one pass with memblock_reserve() and
>another to set up reserved_mem wouldn't help anyway.

Yes. This happens only if there are two many fixed reserved regions.
memblock.reserved can be resized after paging.

I also find another problem. Initializing dynamic reservation after
paging would fail to mark it no-map because no-map flag works when doing
direct mapping. This seems to be a circular dependency.

Thank You,
Calvin

  reply	other threads:[~2021-11-21  9:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-19  7:58 [OpenRISC] [PATCH 0/2] of: remove reserved regions count restriction Calvin Zhang
2021-11-19  7:58 ` [OpenRISC] [PATCH 1/2] of: Sort reserved_mem related code Calvin Zhang
2021-11-30  0:01   ` Rob Herring
2021-11-19  7:58 ` [OpenRISC] [PATCH 2/2] of: reserved_mem: Remove reserved regions count restriction Calvin Zhang
2021-11-19  9:56   ` Andy Shevchenko
2021-11-19 10:27     ` Calvin Zhang
2021-11-19 10:30     ` Calvin Zhang
2021-11-21  6:43 ` [OpenRISC] [PATCH 0/2] of: remove " Mike Rapoport
2021-11-21  9:01   ` Calvin Zhang [this message]
2021-11-30  0:08   ` Rob Herring
2021-11-30 21:07     ` Mike Rapoport

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YZoK4IiBOTPduEyN@debian \
    --to=calvinzhang.cool@gmail.com \
    --cc=openrisc@lists.librecores.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox