[OpenRISC] [PATCH v3 05/13] or1k: Thread Local Storage support

Adhemerval Zanella
2021-12-16T19:33:37Z

On 16/12/2021 16:26, Joseph Myers wrote:
> On Thu, 16 Dec 2021, Adhemerval Zanella via Libc-alpha wrote:
>
>>> +/* Default to an executable stack. PF_X can be overridden if PT_GNU_STACK is
>>> + present, but it is presumed absent. */
>>> +#define DEFAULT_STACK_PERMS (PF_R | PF_W | PF_X)
>>
>> Do you really a default stack executable? It is only done for older ABIs
>> and that's why PT_GNU_STACK was created. Newer ports, like arc and csky
>> assumes otherwise.
>
> I think this reflects what the kernel does (the relevant definitions being
> elf_read_implies_exec and VM_STACK_DEFAULT_FLAGS / VM_DATA_DEFAULT_FLAGS,
> none of which are overridden for openrisc, so the default
> VM_DATA_DEFAULT_FLAGS definition of VM_DATA_FLAGS_EXEC applies).
>

Fair enough, this part is correct then.