From: Stafford Horne <shorne@gmail.com>
To: openrisc@lists.librecores.org
Subject: [OpenRISC] [PATCH v3 11/13] or1k: Build Infrastructure
Date: Thu, 23 Dec 2021 16:32:50 +0900 [thread overview]
Message-ID: <YcQmIj5I+LVCuVI4@antec> (raw)
In-Reply-To: <b0f89bba-6792-27c3-5bed-f10a14f156e9@linaro.org>
On Wed, Dec 22, 2021 at 06:03:27PM -0300, Adhemerval Zanella wrote:
>
>
> On 10/12/2021 20:34, Stafford Horne via Libc-alpha wrote:
> > Here we define the minumum linux kernel version at 5.4.0, as that is the
> > long term support version where 32-bit architectures start to support
> > 64-bit time API's. The OpenRISC kernel had some bugs up until version 5.8
> > which caused issues with glibc fork/clone, they have been backported to
> > 5.4 but not previous versions.
>
> Some comments below, the rest looks ok.
>
> > ---
> > sysdeps/or1k/Implies | 3 ++
> > sysdeps/or1k/Makefile | 7 +++++
> > sysdeps/or1k/nofpu/Implies | 1 +
> > sysdeps/or1k/nptl/Makefile | 21 +++++++++++++
> > sysdeps/or1k/preconfigure | 34 +++++++++++++++++++++
> > sysdeps/unix/sysv/linux/or1k/Implies | 3 ++
> > sysdeps/unix/sysv/linux/or1k/Makefile | 12 ++++++++
> > sysdeps/unix/sysv/linux/or1k/configure | 4 +++
> > sysdeps/unix/sysv/linux/or1k/configure.ac | 4 +++
> > sysdeps/unix/sysv/linux/or1k/shlib-versions | 2 ++
> > 10 files changed, 91 insertions(+)
> > create mode 100644 sysdeps/or1k/Implies
> > create mode 100644 sysdeps/or1k/Makefile
> > create mode 100644 sysdeps/or1k/nofpu/Implies
> > create mode 100644 sysdeps/or1k/nptl/Makefile
> > create mode 100644 sysdeps/or1k/preconfigure
> > create mode 100644 sysdeps/unix/sysv/linux/or1k/Implies
> > create mode 100644 sysdeps/unix/sysv/linux/or1k/Makefile
> > create mode 100644 sysdeps/unix/sysv/linux/or1k/configure
> > create mode 100644 sysdeps/unix/sysv/linux/or1k/configure.ac
> > create mode 100644 sysdeps/unix/sysv/linux/or1k/shlib-versions
> >
> > diff --git a/sysdeps/or1k/Implies b/sysdeps/or1k/Implies
> > new file mode 100644
> > index 0000000000..387a0ca052
> > --- /dev/null
> > +++ b/sysdeps/or1k/Implies
> > @@ -0,0 +1,3 @@
> > +wordsize-32
> > +ieee754/dbl-64
> > +ieee754/flt-32
> > diff --git a/sysdeps/or1k/Makefile b/sysdeps/or1k/Makefile
> > new file mode 100644
> > index 0000000000..0241a0587e
> > --- /dev/null
> > +++ b/sysdeps/or1k/Makefile
> > @@ -0,0 +1,7 @@
> > +ASFLAGS-.os += -fPIC
> > +
> > +ifeq ($(subdir),elf)
> > +# Extra shared linker files to link only into dl-allobjs.so.
> > +sysdep-rtld-routines += dl-start
> > +endif
> > +
> > diff --git a/sysdeps/or1k/nofpu/Implies b/sysdeps/or1k/nofpu/Implies
> > new file mode 100644
> > index 0000000000..abcbadb25f
> > --- /dev/null
> > +++ b/sysdeps/or1k/nofpu/Implies
> > @@ -0,0 +1 @@
> > +ieee754/soft-fp
> > diff --git a/sysdeps/or1k/nptl/Makefile b/sysdeps/or1k/nptl/Makefile
> > new file mode 100644
> > index 0000000000..0e08821933
> > --- /dev/null
> > +++ b/sysdeps/or1k/nptl/Makefile
> > @@ -0,0 +1,21 @@
> > +# Copyright (C) 2021 Free Software Foundation, Inc.
> > +#
> > +# This file is part of the GNU C Library.
> > +#
> > +# The GNU C Library is free software; you can redistribute it and/or
> > +# modify it under the terms of the GNU Lesser General Public
> > +# License as published by the Free Software Foundation; either
> > +# version 2.1 of the License, or (at your option) any later version.
> > +#
> > +# The GNU C Library is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > +# Lesser General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU Lesser General Public
> > +# License along with the GNU C Library. If not, see
> > +# <https://www.gnu.org/licenses/>.
> > +
> > +ifeq ($(subdir),csu)
> > +gen-as-const-headers += tcb-offsets.sym
> > +endif
>
> I think you do not need this anymore since 691d9ae9e6f3bcb.
Yes, I have removed it locally already.
> > diff --git a/sysdeps/or1k/preconfigure b/sysdeps/or1k/preconfigure
> > new file mode 100644
> > index 0000000000..d1b1fb1843
> > --- /dev/null
> > +++ b/sysdeps/or1k/preconfigure
> > @@ -0,0 +1,34 @@
> > +#
> > +# This is free and unencumbered software released into the public domain.
> > +#
> > +# Anyone is free to copy, modify, publish, use, compile, sell, or
> > +# distribute this software, either in source code form or as a compiled
> > +# binary, for any purpose, commercial or non-commercial, and by any
> > +# means.
> > +#
> > +# In jurisdictions that recognize copyright laws, the author or authors
> > +# of this software dedicate any and all copyright interest in the
> > +# software to the public domain. We make this dedication for the benefit
> > +# of the public at large and to the detriment of our heirs and
> > +# successors. We intend this dedication to be an overt act of
> > +# relinquishment in perpetuity of all present and future rights to this
> > +# software under copyright law.
> > +#
> > +# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
> > +# EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
> > +# MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
> > +# IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY CLAIM, DAMAGES OR
> > +# OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
> > +# ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
> > +# OTHER DEALINGS IN THE SOFTWARE.
> > +#
> > +
> > +case "$machine" in
> > +or1k*)
> > + base_machine=or1k
> > + machine=or1k
> > +
> > + with_fp_cond="defined __or1k_hard_float__"
> > + ;;
> > +esac
> > +
> > diff --git a/sysdeps/unix/sysv/linux/or1k/Implies b/sysdeps/unix/sysv/linux/or1k/Implies
> > new file mode 100644
> > index 0000000000..f39f16c04a
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/Implies
> > @@ -0,0 +1,3 @@
> > +or1k/nptl
> > +unix/sysv/linux/generic/wordsize-32
> > +unix/sysv/linux/generic
> > diff --git a/sysdeps/unix/sysv/linux/or1k/Makefile b/sysdeps/unix/sysv/linux/or1k/Makefile
> > new file mode 100644
> > index 0000000000..be20320b2f
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/Makefile
> > @@ -0,0 +1,12 @@
> > +ifeq ($(subdir),misc)
> > + sysdep_routines += prctl or1k_clone
>
> The indentations seems off here and I think there is no need of prctl.
OK.
> > +endif
> > +
> > +ifeq ($(subdir),stdlib)
> > +gen-as-const-headers += ucontext_i.sym
> > +endif
> > +
> > +# pull in __syscall_error routine
> > +libpthread-routines += sysdep
> > +librt-routines += sysdep
Also, I don't think these are needed. I don't see them on new ports.
I think its after moving libpthread and librt into libc.
> > diff --git a/sysdeps/unix/sysv/linux/or1k/configure b/sysdeps/unix/sysv/linux/or1k/configure
> > new file mode 100644
> > index 0000000000..5225dfea5b
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/configure
> > @@ -0,0 +1,4 @@
> > +# This file is generated from configure.ac by Autoconf. DO NOT EDIT!
> > + # Local configure fragment for sysdeps/unix/sysv/linux/or1k.
> > +
> > +arch_minimum_kernel=5.4.0
> > diff --git a/sysdeps/unix/sysv/linux/or1k/configure.ac b/sysdeps/unix/sysv/linux/or1k/configure.ac
> > new file mode 100644
> > index 0000000000..6274c4fb02
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/configure.ac
> > @@ -0,0 +1,4 @@
> > +GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
> > +# Local configure fragment for sysdeps/unix/sysv/linux/or1k.
> > +
> > +arch_minimum_kernel=5.4.0
> > diff --git a/sysdeps/unix/sysv/linux/or1k/shlib-versions b/sysdeps/unix/sysv/linux/or1k/shlib-versions
> > new file mode 100644
> > index 0000000000..159653b5c4
> > --- /dev/null
> > +++ b/sysdeps/unix/sysv/linux/or1k/shlib-versions
> > @@ -0,0 +1,2 @@
> > +DEFAULT GLIBC_2.35
> > +ld=ld-linux-or1k.so.1
next prev parent reply other threads:[~2021-12-23 7:32 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 23:34 [OpenRISC] [PATCH v3 00/13] Glibc OpenRISC port Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 01/13] elf: Add reloc for OpenRISC Stafford Horne
2021-12-14 20:28 ` Adhemerval Zanella
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 02/13] linux/syscalls: Add or1k_atomic syscall " Stafford Horne
2021-12-14 20:29 ` Adhemerval Zanella
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 03/13] or1k: ABI Implementation Stafford Horne
2021-12-14 20:53 ` Adhemerval Zanella
2021-12-14 22:43 ` Joseph Myers
2021-12-15 1:15 ` Adhemerval Zanella
2021-12-15 23:33 ` Stafford Horne
2021-12-16 10:30 ` Adhemerval Zanella
2021-12-16 21:28 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 04/13] or1k: startup and dynamic linking code Stafford Horne
2021-12-16 10:42 ` Adhemerval Zanella
2021-12-17 23:03 ` Stafford Horne
2021-12-20 19:45 ` Adhemerval Zanella
2021-12-20 21:40 ` Stafford Horne
2021-12-21 11:09 ` Adhemerval Zanella
2021-12-21 11:46 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 05/13] or1k: Thread Local Storage support Stafford Horne
2021-12-16 11:35 ` Adhemerval Zanella
2021-12-16 12:37 ` Adhemerval Zanella
2021-12-16 19:26 ` Joseph Myers
2021-12-16 19:33 ` Adhemerval Zanella
2021-12-17 14:23 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 06/13] or1k: Atomics and Locking primitives Stafford Horne
2021-12-16 12:52 ` Adhemerval Zanella
2021-12-16 19:43 ` Adhemerval Zanella
2021-12-17 15:03 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 07/13] or1k: math soft float support Stafford Horne
2021-12-16 19:48 ` Adhemerval Zanella
2021-12-17 15:02 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 08/13] or1k: Linux Syscall Interface Stafford Horne
2021-12-16 21:17 ` Adhemerval Zanella
2021-12-17 15:01 ` Stafford Horne
2021-12-17 17:41 ` Adhemerval Zanella
2021-12-20 11:53 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 09/13] or1k: Linux ABI Stafford Horne
2021-12-21 13:41 ` Adhemerval Zanella
2021-12-21 14:54 ` Stafford Horne
2021-12-22 10:54 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 10/13] or1k: ABI lists Stafford Horne
2021-12-22 20:20 ` Adhemerval Zanella
2021-12-23 8:36 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 11/13] or1k: Build Infrastructure Stafford Horne
2021-12-22 21:03 ` Adhemerval Zanella
2021-12-23 7:32 ` Stafford Horne [this message]
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 12/13] build-many-glibcs.py: add OpenRISC support Stafford Horne
2021-12-22 21:04 ` Adhemerval Zanella
2021-12-23 7:15 ` Stafford Horne
2021-12-10 23:34 ` [OpenRISC] [PATCH v3 13/13] Documentation for OpenRISC port Stafford Horne
2021-12-23 12:57 ` Adhemerval Zanella
2021-12-14 20:25 ` [OpenRISC] [PATCH v3 00/13] Glibc " Adhemerval Zanella
2021-12-15 1:19 ` Adhemerval Zanella
2021-12-15 5:34 ` Stafford Horne
2021-12-15 5:37 ` Stafford Horne
2021-12-23 15:46 ` Stafford Horne
2021-12-23 15:57 ` Andreas Schwab
2021-12-23 21:26 ` Stafford Horne
2021-12-25 7:24 ` Stafford Horne
2021-12-25 22:44 ` Stafford Horne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YcQmIj5I+LVCuVI4@antec \
--to=shorne@gmail.com \
--cc=openrisc@lists.librecores.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox